feat(storefront): re-land the agent chat widget (revert of the rc0 carve-out)#801
Open
bussyjd wants to merge 3 commits into
Open
feat(storefront): re-land the agent chat widget (revert of the rc0 carve-out)#801bussyjd wants to merge 3 commits into
bussyjd wants to merge 3 commits into
Conversation
This reverts commit 78c78a8.
…-EOA gap Two review fixes on the session-wallet widget: - Per-turn payment policy capped at the price shown at page load (bounded by the session balance), not the whole balance. A seller that drifts the price up mid-session can no longer silently drain a funded session in one message; an over-price turn is refused with an honest error, and a missing/zero amount is dropped rather than treated as free. A legit price change is picked up on reload. - Document the MPC/threshold-ECDSA residual: such wallets are code-less EOAs that pass the contract-wallet guard but sign non-deterministically, stranding session funds. No on-chain detection without a second signature popup this flow avoids; noted at the guard and in assets/README.md limitations. Claude-Session: https://claude.ai/code/session_01PnhCQLz7CHuDBUhWd5xF8v
bussyjd
marked this pull request as ready for review
July 20, 2026 18:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-lands the browser chat widget stack that
78c78a86carved out of v0.14.0-rc0 (#752 agent-chat-widget, #762 chat-siwe-session, #785 chat-widget-hardening) — a cleangit revertof the carve-out, nothing else.Why re-land now
The carve-out deferred the widget pending a rework on x402 batch-settlement, but the widget is already running in production (silvernuc3, built from
c2d5c58) and was live-validated today end-to-end on Base mainnet: connect → one sign-in signature (deterministic burner session key) → one funding transfer → silent per-turnexactpayments (no wallet popups) → withdraw back to the main wallet confirmed working. Keeping it out of the tree just makes prod a permanent off-release drift; in-tree and reviewable beats deployed-but-unversioned.Status / open questions
exactsettles remain per-message on-chain txs; that cost/latency profile is the rework's motivation.go build ./...+ controller/x402 test suites green on the revert.https://claude.ai/code/session_01PnhCQLz7CHuDBUhWd5xF8v