Skip to content

compose: pass SHADOW_SCORE_MODEL through to validator + test runner#207

Merged
that-guy-wade merged 1 commit into
mainfrom
sethschilbe/shadow-score-env-passthrough
Jun 28, 2026
Merged

compose: pass SHADOW_SCORE_MODEL through to validator + test runner#207
that-guy-wade merged 1 commit into
mainfrom
sethschilbe/shadow-score-env-passthrough

Conversation

@that-guy-wade

Copy link
Copy Markdown
Contributor

Description

The opt-in shadow rule-score logger added in #205 reads the model name from `SHADOW_SCORE_MODEL` in the container's process environment. Docker Compose only forwards env vars listed in the service `environment` block, so without this pass-through the variable set on the host (`.env` or shell) never reaches the validator process.

Adds the same `${SHADOW_SCORE_MODEL:-}` pattern we already use for every other knob (sandbox workers, reasoning workers, watchtower token, …) to both the validator service and the test runner so local replay scripts behave the same way operationally. Behaviour unchanged when the variable is unset.

Changes Made

  • `docker-compose.yml`: add `SHADOW_SCORE_MODEL=${SHADOW_SCORE_MODEL:-}` to the `validator` service `environment` block.
  • Same on the `test` runner so `docker compose run test ...` matches operational behaviour.

Issue Link

  • Related to: N/A
  • Closes: N/A

Testing

Manual Testing

Verified locally and on a remote validator: with the env var set on the host and the equivalent pass-through line in compose, `docker exec oro-validator-1 env | grep SHADOW` returns the configured model name. Without the pass-through it returns nothing.

Test Results: Pass-through works as expected.

Automated Testing

N/A — config-only change.

Test Command(s):

```bash
docker compose --profile validator config | grep SHADOW
```

Documentation

  • README updated
  • Code comments added/updated
  • API documentation updated
  • Configuration documentation updated
  • Other documentation updated (please specify):

Documentation Changes: Inline comments on both env entries explain the opt-in semantics.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published and merged

Additional Notes

External validator operators see no behaviour change unless they explicitly set `SHADOW_SCORE_MODEL` in their `.env`.

The opt-in shadow rule-score logger added in #205 reads the model name
from `SHADOW_SCORE_MODEL` in the container's process environment.
Docker Compose only forwards env vars listed in the service `environment`
block, so without this pass-through the variable set on the host (.env or
shell) never reaches the validator process.

Adds the same `${SHADOW_SCORE_MODEL:-}` pattern we already use for every
other knob (sandbox workers, reasoning workers, watchtower token, …) to
both the validator service and the test runner so local replay scripts
behave the same way operationally.

Behaviour unchanged when the variable is unset.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@that-guy-wade that-guy-wade self-assigned this Jun 28, 2026
@that-guy-wade that-guy-wade requested a review from shardi-b June 28, 2026 20:53

@shardi-b shardi-b left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. No issues found during code review.

@that-guy-wade that-guy-wade merged commit 6d10f51 into main Jun 28, 2026
6 checks passed
@that-guy-wade that-guy-wade deleted the sethschilbe/shadow-score-env-passthrough branch June 28, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants