compose: pass SHADOW_SCORE_MODEL through to validator + test runner#207
Merged
Merged
Conversation
The opt-in shadow rule-score logger added in #205 reads the model name from `SHADOW_SCORE_MODEL` in the container's process environment. Docker Compose only forwards env vars listed in the service `environment` block, so without this pass-through the variable set on the host (.env or shell) never reaches the validator process. Adds the same `${SHADOW_SCORE_MODEL:-}` pattern we already use for every other knob (sandbox workers, reasoning workers, watchtower token, …) to both the validator service and the test runner so local replay scripts behave the same way operationally. Behaviour unchanged when the variable is unset. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
shardi-b
approved these changes
Jun 28, 2026
shardi-b
left a comment
Contributor
There was a problem hiding this comment.
Approved. No issues found during code review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The opt-in shadow rule-score logger added in #205 reads the model name from `SHADOW_SCORE_MODEL` in the container's process environment. Docker Compose only forwards env vars listed in the service `environment` block, so without this pass-through the variable set on the host (`.env` or shell) never reaches the validator process.
Adds the same `${SHADOW_SCORE_MODEL:-}` pattern we already use for every other knob (sandbox workers, reasoning workers, watchtower token, …) to both the validator service and the test runner so local replay scripts behave the same way operationally. Behaviour unchanged when the variable is unset.
Changes Made
Issue Link
Testing
Manual Testing
Verified locally and on a remote validator: with the env var set on the host and the equivalent pass-through line in compose, `docker exec oro-validator-1 env | grep SHADOW` returns the configured model name. Without the pass-through it returns nothing.
Test Results: Pass-through works as expected.
Automated Testing
N/A — config-only change.
Test Command(s):
```bash
docker compose --profile validator config | grep SHADOW
```
Documentation
Documentation Changes: Inline comments on both env entries explain the opt-in semantics.
Checklist
Additional Notes
External validator operators see no behaviour change unless they explicitly set `SHADOW_SCORE_MODEL` in their `.env`.