Refactor curl::http_get_and_write_resource() to use passed in request_headers#1394
Open
ndp-opendap wants to merge 11 commits into
Open
Refactor curl::http_get_and_write_resource() to use passed in request_headers#1394ndp-opendap wants to merge 11 commits into
ndp-opendap wants to merge 11 commits into
Conversation
…ad of embedding EDL things way down in the call tree.
Contributor
|
I believe it looks good. Do the other Tasks like tests and TODOs need to be added/checked before this can be closed out? |
|
|
|
… looks in the BESContextManager and in the Credentials manager for EDL tokens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the curl::http_get_and_write_resource() ecosystem to support passing in HTTP request headers so that top level code which knows that the request may need to be authenticated can handle creating the associated headers and not rely on having the request authentication semantics baked into the http/curl package.
This is one step in resolving the linked issue regarding broadcasting EDL authentication information.
Reference ticket: There is no HYRAX ticket.
Tasks