Control authentication scope for the curl::http_get_and_write_resource() function#1392
Closed
ndp-opendap wants to merge 4 commits into
Closed
Control authentication scope for the curl::http_get_and_write_resource() function#1392ndp-opendap wants to merge 4 commits into
ndp-opendap wants to merge 4 commits into
Conversation
|
|
|
Contributor
Author
|
also migrated the SONAR API to sonar.token from sonar.login and put the token value in TravisCI settings and not in the .travis.yml file. One token for all the targets, on token to rule them all, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reference ticket: HYRAX-####
This PR amends the function
curl::http_get_and_write_resource()so that it can be asked to conditionally add authentication information to the outgoing request headers. Currently it always adds these headers, even when that's not useful.curl::http_get_and_write_resource()is used in exactly one place,RemoteResource::get_url(). Which, in turn, is only ever called byRemoteResource::retrieve_resource, which is widely used.Here's is the how the change affects the dependent code:
CmrContainer.cc- Uses EDL to authenticate with CMRGatewayContainer.cc- No AuthHttpdCatalogContainer.cc- No AuthJsonUtils.cc- Exclusively used by the CmrApi to interrogate CMR. Uses EDL to authenticate with CMRS3Container.cc- Authenticates (I think with S3 signing headers)This PR addresses the authentication needs and stops authentication headers from being broadcast by Gateway and HttpdCatalog.
Tasks