[19.0][MIG] sale_tier_validation

[alan196]

No description provided.

[bosd]

@alan196 Thanks for the work.
Can you please add a test-requirements.txt ?

odoo-addon-base_tier_validation @ git+https://github.com/OCA/tier-validation@refs/pull/1/head#subdirectory=base_tier_validation

So it depends on: #1

Can you apply the changes from the other pr OCA/sale-workflow@8f68ae7#diff-39d65b4f67c6dd0ae59a6ac23b4f6551fc150996b6e0fa2410e37c840056a7b8

Please squash the administrative commits

[OpenCode]

@alan196 Thanks for the work. Can you please add a test-requirements.txt ?

odoo-addon-base_tier_validation @ git+https://github.com/OCA/tier-validation@refs/pull/1/head#subdirectory=base_tier_validation

So it depends on: #1

Can you apply the changes from the other pr OCA/sale-workflow@8f68ae7#diff-39d65b4f67c6dd0ae59a6ac23b4f6551fc150996b6e0fa2410e37c840056a7b8

Please squash the administrative commits

PR #1 is closed. Now you can use #13

[bosd]

@alan196 Can you please update this pr?

[bosd]

Heads-up: filter domain breaks registry load on Odoo 19

Running -i sale_tier_validation on a 19.0 instance crashes at view load with:

odoo.tools.convert.ParseError: while parsing sale_tier_validation/views/sale_order_view.xml:5
Error while validating view near:

  <search string="Search Sales Order">
  …

Unknown field "sale.order.validated" in domain of <filter name="tier_validated"> ([('validated', '=', True)])

Cause

base_tier_validation 19.0 still exposes validated as a non-stored compute Boolean with search=_search_validated:

# TODO: Delete in v19 in favor of validation_status field
validated = fields.Boolean(
    compute="_compute_validated_rejected", search="_search_validated"
)

Odoo 19's view validator no longer accepts that pattern in a search-view domain when the field comes in via an AbstractModel _inherit. The view dies before the install can complete, so the whole registry init fails.

Suggested fix

Swap the filter to the stored validation_status Selection field (already defined in base_tier_validation, value 'validated' is the same end-state):

<filter
    name="tier_validated"
    string="Validated"
    domain="[('validation_status', '=', 'validated')]"
    help="SOs validated and ready to be confirmed"
/>

This matches the base_tier_validation TODO note that validated is being phased out in favor of validation_status in v19. One-line view change, no model changes needed; tested on a real 19.0 install (where the unpatched filter reproduces the crash above and the patched one loads cleanly).

[Yusuke1998]

@alan196 Hi, some modules have already been migrated, so you might not need a test-requirements document. Could you check it? I think this pull request won't be approved until you have at least a test and runboat application running.

[bosd]

this pull request won't be approved until you have at least a test and runboat a

@alan196 A simple rebase will likely turn tests green. 🤞
Can you try it?

[OpenCode]

@alan196 Can you rebase and push so the CI/CD can run again?

[bosd]

@OpenCode
Maybe @alan196 is no longer active?

[kirca]

I created a new PR #55 because this one was stale