[19.0] [MIG] mail_template_multi_company : Migration to 19.0#990
[19.0] [MIG] mail_template_multi_company : Migration to 19.0#990stferraro wants to merge 23 commits into
Conversation
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: multi-company-15.0/multi-company-15.0-mail_template_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-15-0/multi-company-15-0-mail_template_multi_company/
Currently translated at 100.0% (2 of 2 strings) Translation: multi-company-16.0/multi-company-16.0-mail_template_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-16-0/multi-company-16-0-mail_template_multi_company/it/
OCA-git-bot
added
series:19.0
mod:mail_template_multi_company
|
Hi, @BhaveshHeliconia please check this review and approve |
stferraro
force-pushed
the
19.0-mig-mail_template_multi_company
branch
from
43e6b47 to
22b3bfd
Compare
| "name": "Restricted User", | ||
| "login": "restricted_user", | ||
| "email": "restricted_user@example.com", | ||
| "group_ids": [(6, 0, [self.env.ref("base.group_user").id])], |
There was a problem hiding this comment.
| "group_ids": [(6, 0, [self.env.ref("base.group_user").id])], | |
| "group_ids": [Command.set([self.env.ref("base.group_user").id])], |
|
@stferraro could you please update the PR title to: [19.0][MIG] mail_template_multi_company: Migration to 19.0 |
stferraro
changed the title
stferraro
force-pushed
the
19.0-mig-mail_template_multi_company
branch
from
22b3bfd to
920c8b1
Compare
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
Code review LGTM!
|
This PR has the |
|
@OCA-git-bot ping . |
|
it seems that this module has some limitations and bugs in multi-company setups (especially with the "Send by Email" button), it falls back to the standard/global template instead of picking the company-specific one. Will this be improved? notes: company_id = record.company_id (or current company) and fall back only if none exists. |
|
Hi, @nivels-rig Thanks for the suggestion! We'll keep this migration scoped to porting the existing behavior. Once this PR is approved, we'll open a separate [IMP] PR to implement company-aware template selection — filtering the template dropdown by the record's company and discarding wrong-company defaults in default_get. |
|
not yet merged? |
15 participants
No description provided.