[19.0][MIG]base_multi_company by Vandan-Pandeji-SerpentCS · Pull Request #889 · OCA/multi-company

Vandan-Pandeji-SerpentCS · 2025-10-14T07:17:19Z

No description provided.

* Create new module to provide base multi company logic and mixin * Add deactivation by company mixin * Add company_id/ids handling * Add break after company is found Squashed commits: [854cc36] Increase test coverage [770bd71] Revert hook view create back to model init [40e803e] Fix apples and oranges [7a4dfb4] Use registry correctly [6e9f170] Switch company_id to computed & move company aliased view creation to post init hook [faa4fc9] Remove active functionality [fecfb59] Add explicit tests for active and inactive searches

* Revert "Revert hook view create back to model init" This reverts commit 770bd71. * [FIX] base_multi_company: Always create the view into a pre_init_hook to avoid error in log

Squashed commits: [4c17d04] auto_join company_ids

…ch domain on company_id/company_ids (+1 squashed commit) Squashed commits: [fe161fe] [ADD] setup.py

- Test if a company is set in inverse method (+1 squashed commit) Squashed commits: [d670f30] [FIX] fix init hooks as company_id is not stored anymore

* Add implementation instructions to ReadMe

[FIX] Fix issue based on the computation of company_id for multi_company_abstract models [FIX] Fix issue based on the computation of company_id for multi_company_abstract models [FIX] Fix issue based on the computation of company_id for multi_company_abstract models [FIX] Bad branch version pushed before [FIX] Bad branch version pushed before [FIX] manifest Fix flake Flake8 on OCA tests

… are bound to some company

Currently translated at 88.9% (8 of 9 strings) Translation: multi-company-10.0/multi-company-10.0-base_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-10-0/multi-company-10-0-base_multi_company/pt/

Odoo now checks if the user who creates the transient model is the same that is accessing its data, so we need to create it with the same user.

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

* Abstract model shouldn't have default for `company_ids`. It will be got by default `company_id` value. * Record rule based on `company_id` makes the evaluation slower. Switch to `company_ids` field. * Add `@api.depends` to `company_id` computation for proper refresh. * Fix tests that were not correct but luckily previously suceeded. Now that other code has been removed, they have been uncovered.

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: multi-company-12.0/multi-company-12.0-base_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-12-0/multi-company-12-0-base_multi_company/

Currently translated at 70.0% (7 of 10 strings) Translation: multi-company-12.0/multi-company-12.0-base_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-12-0/multi-company-12-0-base_multi_company/zh_CN/

[IMP]IMP Code. [FIX] [IMP]

weinni2000

LGTM

OCA-git-bot · 2026-02-17T12:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

JayVora-SerpentCS · 2026-03-05T10:10:49Z

@OCA-git-bot remind the maintainers to merge this Pr pls. cc @weinni2000

astirpe · 2026-03-15T10:10:55Z

@Vandan-Pandeji-SerpentCS I made a PR to your branch, could you check? Vandan-Pandeji-SerpentCS#2

EmilioPascual · 2026-05-08T14:07:53Z

@Vandan-Pandeji-SerpentCS could you add the missing commits since the PR was opened? Thank you.

@moduon MT-14423

EmilioPascual · 2026-05-20T15:04:58Z

@Vandan-Pandeji-SerpentCS could you please check the PR that @astirpe commented you and apply the missing commits? Those comments are quite old. Otherwise, we’ll have to superseed the PR. Thank you.

)

Vandan-Pandeji-SerpentCS · 2026-05-21T05:59:35Z

@Vandan-Pandeji-SerpentCS could you please check the PR that @astirpe commented you and apply the missing commits? Those comments are quite old. Otherwise, we’ll have to superseed the PR. Thank you.

@EmilioPascual Done. Could you please check now?

EmilioPascual · 2026-05-22T06:48:13Z

@Vandan-Pandeji-SerpentCS could you please check the PR that @astirpe commented you and apply the missing commits? Those comments are quite old. Otherwise, we’ll have to superseed the PR. Thank you.

@EmilioPascual Done. Could you please check now?

There are still some commits missing from 18.0 such as 1de1ecc, 35e45c0 or bb502d6

Vandan-Pandeji-SerpentCS · 2026-05-22T09:17:03Z

@Vandan-Pandeji-SerpentCS could you please check the PR that @astirpe commented you and apply the missing commits? Those comments are quite old. Otherwise, we’ll have to superseed the PR. Thank you.

@EmilioPascual Done. Could you please check now?

There are still some commits missing from 18.0 such as 1de1ecc, 35e45c0 or bb502d6

Okay, I'll add it.

Vandan-Pandeji-SerpentCS · 2026-05-25T08:08:45Z

@EmilioPascual
Unit test cases are failing because the pull request at #942 has failed checks. Could you please guide me?

chienandalu · 2026-06-19T08:57:44Z

+            if company_id in sudo_record.company_ids.ids:
+                record.company_id = company_id
+            else:
+                record.company_id = sudo_record.company_ids[:1].id


Testing this module in a complete instance we're having some issues with this compute in certain cases when a NewId enters from an onchange or something like that...

It causes this error:

File "/opt/odoo/custom/src/odoo/odoo/addons/base/models/res_partner.py", line 477, in _compute_same_vat_partner_id partner.same_vat_partner_id = should_check_vat and not partner.parent_id and Partner.search(domain, limit=1) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ psycopg2.ProgrammingError: can't adapt type 'NewId'

This code is more resilient as we tested locally:

Suggested change

if company_id in sudo_record.company_ids.ids:

record.company_id = company_id

else:

record.company_id = sudo_record.company_ids[:1].id

company_ids = sudo_record.company_ids._origin.ids or sudo_record.company_ids.ids

if company_id in company_ids:

record.company_id = company_id

else:

company = sudo_record.company_ids[:1]

if company and isinstance(company.id, models.NewId):

record.company_id = company._origin.id or False

else:

record.company_id = company.id

@chienandalu could you review #1009?
I think I've fixed it

lasley and others added 30 commits October 14, 2025 12:38

10.0 base multi company lmi (#1)

9a2ae97

* Revert "Revert hook view create back to model init" This reverts commit 770bd71. * [FIX] base_multi_company: Always create the view into a pre_init_hook to avoid error in log

PR fixes (+1 squashed commit)

b060d38

Squashed commits: [4c17d04] auto_join company_ids

[FIX] base_multi_company: Allow child_of/parent_of operator into sear…

9eb0949

…ch domain on company_id/company_ids (+1 squashed commit) Squashed commits: [fe161fe] [ADD] setup.py

- Remove depends as company_id is not stored anymore

31398fa

- Test if a company is set in inverse method (+1 squashed commit) Squashed commits: [d670f30] [FIX] fix init hooks as company_id is not stored anymore

OCA Transbot updated translations from Transifex

786b0b7

[IMP] base_multi_company: Improve ReadMe

72380b7

* Add implementation instructions to ReadMe

[MIG] *_multi_company: OpenUpgrade migration scripts

3c842d6

[FIX] Insert in company_ids relation's table only ids of records that…

be4337b

… are bound to some company

[UPD] Update base_multi_company.pot

5503d50

Translated using Weblate (Portuguese)

9ff3b67

Currently translated at 88.9% (8 of 9 strings) Translation: multi-company-10.0/multi-company-10.0-base_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-10-0/multi-company-10-0-base_multi_company/pt/

[MIG] base_multi_company: Migration to 11.0

8ab335c

[UPD] Update base_multi_company.pot

1add850

[FIX] base_multi_company: Fix tests

8c0e33e

Odoo now checks if the user who creates the transient model is the same that is accessing its data, so we need to create it with the same user.

Update translation files

f6cf4d5

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[UPD] Update base_multi_company.pot

1470955

Update translation files

e69a5a2

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

[MIG] partner_multi_company: Finish migration to 11.0

c06c6d8

[UPD] Update base_multi_company.pot

2072c37

Update translation files

12e82d4

Updated by Update PO files to match POT (msgmerge) hook in Weblate.

Migrate base_multi_company to v12

509fbf9

Improve performance adding a techical field used in ir rules

ab20207

fixup! Migrate base_multi_company to v12

26eda68

[UPD] Update base_multi_company.pot

bbe85ad

[UPD] README.rst

c6c44dd

Update translation files

7c60447

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: multi-company-12.0/multi-company-12.0-base_multi_company Translate-URL: https://translation.odoo-community.org/projects/multi-company-12-0/multi-company-12-0-base_multi_company/

Added translation using Weblate (Chinese (Simplified))

37f5107

Vandan-Pandeji-SerpentCS mentioned this pull request Nov 4, 2025

[MIG][19.0] partner_multi_company #901

Open

[MIG] base_multi_company: Migration to 19.0

11bb692

[IMP]IMP Code. [FIX] [IMP]

Vandan-Pandeji-SerpentCS force-pushed the 19.0-MIG-base_multi_company branch from 57201c2 to 11bb692 Compare November 4, 2025 13:46

weinni2000 approved these changes Dec 4, 2025

View reviewed changes

bizzappdev mentioned this pull request Dec 11, 2025

[19.0][MIG] product_multi_company: Migration to 19.0 #917

Open

Murtaza-OSI approved these changes Feb 17, 2026

View reviewed changes

OCA-git-bot added approved ready to merge labels Feb 17, 2026

This was referenced Mar 14, 2026

[19.0][IMP] partner_multi_company #972

Draft

[19.0][MIG] base_multi_company #973

Draft

[19.0][IMP] base_multi_company: fix access errors and add robustness (#2

9e23242

)

OCA-git-bot added series:19.0 mod:base_multi_company Module base_multi_company labels May 21, 2026

Vandan-Pandeji-SerpentCS force-pushed the 19.0-MIG-base_multi_company branch 4 times, most recently from b61759a to 7d357a5 Compare May 25, 2026 06:31

[IMP] base_multi_company: V19 unit test cases.

0fd2a47

Vandan-Pandeji-SerpentCS force-pushed the 19.0-MIG-base_multi_company branch from 7d357a5 to 0fd2a47 Compare May 25, 2026 06:37

EmilioPascual mentioned this pull request Jun 3, 2026

[19.0][MIG] base_multi_company #1009

Open

chienandalu reviewed Jun 19, 2026

View reviewed changes

-            if company_id in sudo_record.company_ids.ids:
-                record.company_id = company_id
-            else:
-                record.company_id = sudo_record.company_ids[:1].id
+            company_ids = sudo_record.company_ids._origin.ids or sudo_record.company_ids.ids
+            if company_id in company_ids:
+                record.company_id = company_id
+            else:
+                company = sudo_record.company_ids[:1]
+                if company and isinstance(company.id, models.NewId):
+                    record.company_id = company._origin.id or False
+                else:
+                    record.company_id = company.id

Uh oh!

Uh oh!

Conversation

Vandan-Pandeji-SerpentCS commented Oct 14, 2025

Uh oh!

weinni2000 left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Feb 17, 2026

Uh oh!

JayVora-SerpentCS commented Mar 5, 2026

Uh oh!

astirpe commented Mar 15, 2026

Uh oh!

EmilioPascual commented May 8, 2026

Uh oh!

EmilioPascual commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Vandan-Pandeji-SerpentCS commented May 21, 2026

Uh oh!

EmilioPascual commented May 22, 2026

Uh oh!

Vandan-Pandeji-SerpentCS commented May 22, 2026

Uh oh!

Vandan-Pandeji-SerpentCS commented May 25, 2026

Uh oh!

chienandalu Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

EmilioPascual Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

EmilioPascual commented May 20, 2026 •

edited

Loading