[19.0][IMP] mis_builder: expand KPI detail rows by partner - #817
Open
max3903 wants to merge 3 commits into
Open
Conversation
Allow KPIs to display one detail row per partner in addition to the existing account expansion, via a new detail_by field that keeps auto_expand_accounts for backward compatibility.
Contributor
|
Hi @sbidoul, |
Treat False like None when packing cell ids so notes match parent KPI cells (empty middle segment), not the literal string "False".
max3903
force-pushed
the
19.0-detail-by-partner
branch
from
July 20, 2026 16:58
844d38a to
4a4f4a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
detail_byselection (none/account/partner) so report rows can expand one line per partner, not only per account.auto_expand_accountsas a stored compute/inverse for backward compatibility, with a post-migration mapping existing flags todetail_by=account.0= empty partner).Test plan
mis_builderto19.0.1.1.0and confirm KPIs withauto_expand_accountsstill expand by accountdetail_by=partneron receivable/payable expressions and verify one row per partner (+ “(No partner)” when empty)partner_idmis_builder.tests.test_partner_detailand existing auto-expand tests (test_data_sources)Made with Cursor