[19.0][MIG] hr_expense_invoice

[Shide]

Superseeds #357

A lot of refactor because hr_expense_sheet has been removed and the workflow has been changed completely.

Also, the normal workflow of Odoo 19 to create bills/receipts has been improved and this migration maintains the "old way" to create vendor bills.

https://www.loom.com/share/4444b9a7188e42fea9d7f14bcc8c01f8

MT-14679 @moduon @rafaelbn @pedrobaeza @victoralmau please review if you want 😄

[Shide]

Tests are not refactored and will fail should fail at this point.

I want to review the current workflow @pedrobaeza to know if it's consistent.

I'm open to modify anything

[rafaelbn]

Hello @pedrobaeza , there is a 4 minutes video explaining the work 😄 , as there are changes in Odoo 19 in the expense workflow.

We are migrating to 19 and any change you are not agree would be dificult to resolve.

If you have 10 minutes, it could be apreciated

Thank!

[Gelojr]

The implementation works correctly for the standard scenarios that were tested:

• Test 1: Expense not linked to a vendor bill, paid by the employee – OK.
• Test 2: Expense not linked to a vendor bill, paid by the company – OK.
• Test 3: Expense linked to a vendor bill, paid by the employee – OK. Note: If the product uses a "Not Applicable" tax, the invoice amount and tax must be adjusted manually.
• Test 4: Expense linked to a vendor bill, paid by the company – OK. Note: The vendor bill must be reset to draft to manually adjust the amount and tax if the tax is incorrect.

However, I found a blocking issue in the following scenario:

Steps to reproduce:

1. Create an expense for €200 with a "Not Applicable" tax.
2. Approve the expense.
3. Generate vendor bill, set the untaxed amount to €200 and apply a 21% tax, resulting in a total of €242, then save the bill.
4. Odoo correctly prevents saving the changes with the message: "You cannot modify the total amount because there is an expense linked to this bill."
5. Discard the changes and try to delete the vendor bill to recreate it. The same error is displayed.
6. Go back to the expense and try to reset it to draft. The same error is displayed.
7. Try rejecting the expense. The status does not change.

Result:
The expense and vendor bill become locked in an inconsistent state and there is no way for the user to recover from this situation. Even though the original modification is correctly blocked, the linked documents cannot be corrected afterwards.

Could you please review this case? It seems the rollback/recovery flow should allow the user to recover from this situation instead of leaving both records blocked.

[Shide]

The implementation works correctly for the standard scenarios that were tested:

• Test 1: Expense not linked to a vendor bill, paid by the employee – OK.
• Test 2: Expense not linked to a vendor bill, paid by the company – OK.
• Test 3: Expense linked to a vendor bill, paid by the employee – OK. Note: If the product uses a "Not Applicable" tax, the invoice amount and tax must be adjusted manually.
• Test 4: Expense linked to a vendor bill, paid by the company – OK. Note: The vendor bill must be reset to draft to manually adjust the amount and tax if the tax is incorrect.

However, I found a blocking issue in the following scenario:

Steps to reproduce:

1. Create an expense for €200 with a "Not Applicable" tax.
2. Approve the expense.
3. Generate vendor bill, set the untaxed amount to €200 and apply a 21% tax, resulting in a total of €242, then save the bill.
4. Odoo correctly prevents saving the changes with the message: "You cannot modify the total amount because there is an expense linked to this bill."
5. Discard the changes and try to delete the vendor bill to recreate it. The same error is displayed.
6. Go back to the expense and try to reset it to draft. The same error is displayed.
7. Try rejecting the expense. The status does not change.

Result: The expense and vendor bill become locked in an inconsistent state and there is no way for the user to recover from this situation. Even though the original modification is correctly blocked, the linked documents cannot be corrected afterwards.

Could you please review this case? It seems the rollback/recovery flow should allow the user to recover from this situation instead of leaving both records blocked.

You can:

1. un-link the invoice from the Expense
2. Modify the invoice
3. Link the Invoice again from the Expense

[Gelojr]

Nice job @Shide
The following tests have been performed:

Test 1: Expense not linked to a vendor bill, paid by the employee – OK.

Test 2: Expense not linked to a vendor bill, paid by the company – OK.

Test 3: Expense linked to a vendor bill, paid by the employee – OK. Note: If the product uses a "Not Applicable" tax, the invoice amount and tax must be adjusted manually.

Test 4: Expense linked to a vendor bill, paid by the company – OK. Note: The vendor bill must be reset to draft to manually adjust the amount and tax if the tax is incorrect.

Test 5: Vendor bill linked to an expense paid by the employee – OK. The previous issue was resolved by following @Shide 's instructions.

Test 6: Vendor bill linked to an expense paid by the company – OK.

The PR is approved.

As a possible improvement for future iterations, it may be worth reviewing whether vendor bills generated during this workflow should remain in draft state until all required information has been completed by the user. Publishing them automatically before the final review could potentially cause issues in environments with fiscal reporting integrations such as SII, TicketBAI or Batuz, where posted documents may be sent automatically.