[18.0][MIG] hr_expense_advance_overdue_reminder: Migration to 18.0#363
Open
ROBBYHOOD9 wants to merge 17 commits into
Open
[18.0][MIG] hr_expense_advance_overdue_reminder: Migration to 18.0#363ROBBYHOOD9 wants to merge 17 commits into
ROBBYHOOD9 wants to merge 17 commits into
Conversation
Currently translated at 100.0% (102 of 102 strings) Translation: hr-expense-15.0/hr-expense-15.0-hr_expense_advance_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/hr-expense-15-0/hr-expense-15-0-hr_expense_advance_overdue_reminder/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-expense-15.0/hr-expense-15.0-hr_expense_advance_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/hr-expense-15-0/hr-expense-15-0-hr_expense_advance_overdue_reminder/
Currently translated at 99.0% (100 of 101 strings) Translation: hr-expense-15.0/hr-expense-15.0-hr_expense_advance_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/hr-expense-15-0/hr-expense-15-0-hr_expense_advance_overdue_reminder/es/
Currently translated at 100.0% (101 of 101 strings) Translation: hr-expense-15.0/hr-expense-15.0-hr_expense_advance_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/hr-expense-15-0/hr-expense-15-0-hr_expense_advance_overdue_reminder/es/
Currently translated at 100.0% (101 of 101 strings) Translation: hr-expense-15.0/hr-expense-15.0-hr_expense_advance_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/hr-expense-15-0/hr-expense-15-0-hr_expense_advance_overdue_reminder/it/
Currently translated at 100.0% (101 of 101 strings) Translation: hr-expense-15.0/hr-expense-15.0-hr_expense_advance_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/hr-expense-15-0/hr-expense-15-0-hr_expense_advance_overdue_reminder/it/
Currently translated at 100.0% (101 of 101 strings) Translation: hr-expense-15.0/hr-expense-15.0-hr_expense_advance_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/hr-expense-15-0/hr-expense-15-0-hr_expense_advance_overdue_reminder/it/
Currently translated at 100.0% (101 of 101 strings) Translation: hr-expense-15.0/hr-expense-15.0-hr_expense_advance_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/hr-expense-15-0/hr-expense-15-0-hr_expense_advance_overdue_reminder/gl/
OCA-git-bot
added
series:18.0
mod:hr_expense_advance_overdue_reminder
ROBBYHOOD9
force-pushed
the
18.0-mig-hr_expense_advance_overdue_reminder
branch
from
025725b to
cb52487
Compare
Member
|
@ROBBYHOOD9 Could you check and review this PR instead? #326 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration
hr_expense_advance_overdue_reminderfrom 15.0 to 18.01. Module Version
Updated the module version to align with Odoo 18.
"version": "15.0.1.0.0"→"version": "18.0.1.0.0"2. Python Code Updates
Updated Python code to comply with Odoo 18 requirements.
states={...}field attributes and moved readonly logic to views.base.reminder.mixin.@api.model create(vals)with@api.model_create_multi create(vals_list).account_move_idsinstead ofaccount_move_id.UP031, ambiguous lambda variables, context access).3. Functional Updates
Updated logic to support changes introduced in Odoo 18.
privatewithwork_contact_id.work_contact_id.default_res_idsinstead of deprecateddefault_res_id.4. View Migration
Updated XML views to follow the Odoo 17/18 architecture.
attrsexpressions with inline expressions.<tree>with<list>.view_modefromtreetolist.<div class="oe_chatter">with<chatter/>.statesattributes with inline visibility expressions.invisible="1"withcolumn_invisible="1"for list view columns.5. Test Updates
Updated tests to follow newer Odoo conventions.
TestExpenseCommon.work_contact_idanddefault_res_ids.6. Runtime Fixes
Resolved issues discovered during installation and test execution.
reminder_definition_idcausing wizard creation failures.default_res_id/res_idin Odoo 18.Note
Additional fixes were applied to resolve CI failures in Odoo 18:
action_sheet_move_post()to skip overdue reminder processing when noreminder.definitionis configured, preventing failures in related modules.base.group_userto access rules with empty groups to eliminate Odoo 18 CI warnings.These changes do not affect normal functionality when a reminder definition is configured.