[19.0][MIG] hr_expense_employee_payment

[Shide]

Complete refactor because hr expense sheet doesn't exists in v19 and payment flow has been changed too.

https://www.loom.com/share/501d770824e345089396de3f7ae4c931

MT-14678 @moduon @yajo @EmilioPascual @fcvalgar @Gelojr @chienandalu please review if you want 😄

[fcvalgar]

Thanks for the work on this module @Shide . I reviewed the employee-paid expense flows, but I cannot approve it yet because the payment flow is blocked by a validation error in the Purchase Receipt case. When trying to pay a posted employee expense generated as a Purchase Receipt, Odoo raises: “Missing required value for the field ‘Date’ (date). Model: Journal Entry (account.move)”. If Purchase Receipts are not meant to be supported by this module, the flow should be clearly excluded or controlled to avoid this technical error.

Test 1: OK - An employee-paid expense can be created, submitted, approved and posted as a Vendor Bill.
Test 2: OK - The payment flow for an employee-paid expense generated as a Vendor Bill can be completed and the employee reimbursement flow works as expected.
Test 3: OK - The conciliation entry is created and linked to the expense in the Vendor Bill flow.
Test 4: OK - Partial payment support works correctly in the Vendor Bill flow.
Test 5: Not OK - Registering the payment from an employee-paid expense generated as a Purchase Receipt fails with a validation error because the generated journal entry has no Date.
Test 6: Not OK - The conciliation/payment flow for Purchase Receipts cannot be validated because the payment action is blocked by the Date validation error.

Please review the payment/conciliation move creation for the Purchase Receipt flow, or explicitly prevent/control this case if it is outside the intended scope. Once this is fixed or clarified, I can retest the affected flow.

[Gelojr]

A review is required before this PR can be approved. At this stage, I cannot approve the PR because the main payment flow is not working as expected.

The following tests have been performed:

• Test 1: Intermediate Expense Journal Configuration - Verified that Employee Expense Journal and Employee Expense Intermediate Journal can be configured successfully. OK
• Test 2: Expense Creation and Approval Flow - Verified that an employee-paid expense can be created, submitted and approved successfully. OK
• Test 3: Employee Expense Payment Flow - NOK. After configuring "Employee Expense Journal" and "Employee Expense Intermediate Journal" (using "Miscellaneous Operations" as the intermediate journal), an expense was created, submitted and approved successfully. The purchase receipt was generated correctly, but when attempting to proceed with the payment flow, Odoo displayed a warning indicating that the operation could not be completed.

Please review Test 3: Employee Expense Payment Flow.

Steps to reproduce:

1. Configure an Employee Expense Journal.
2. Configure an Employee Expense Intermediate Journal using a Miscellaneous Operations journal.
3. Create an expense paid by the employee.
4. Submit and approve the expense.
5. Generate the purchase receipt through the standard expense workflow.
6. Attempt to proceed with the payment process.
7. Odoo displays a warning indicating that the operation cannot be completed as just like @fcvalgar

[yajo]

Code review.

[fcvalgar]

LGTM, thank you @Shide @yajo

Test 5: OK - Registering the payment from an employee-paid expense generated as a Purchase Receipt fails with a validation error because the generated journal entry has no Date.
Test 6: OK - The conciliation/payment flow for Purchase Receipts cannot be validated because the payment action is blocked by the Date validation error.

[BhaveshHeliconia]

LGTM!