[19.0][MIG] hr_expense_sequence_option: Migration to 19.0#354
Open
dnplkndll wants to merge 10 commits into
Open
[19.0][MIG] hr_expense_sequence_option: Migration to 19.0#354dnplkndll wants to merge 10 commits into
dnplkndll wants to merge 10 commits into
Conversation
OCA-git-bot
added
series:19.0
mod:hr_expense_sequence_option
dnplkndll
force-pushed
the
19.0-mig-hr_expense_sequence_option
branch
2 times, most recently
from
9ad723e to
0c245c3
Compare
dnplkndll
force-pushed
the
19.0-mig-hr_expense_sequence_option
branch
2 times, most recently
from
9a824dd to
0c245c3
Compare
(cherry picked from commit 5b0dbde)
(cherry picked from commit 60e94a4)
(cherry picked from commit 31f835f)
(cherry picked from commit a14b10d)
Currently translated at 100.0% (4 of 4 strings) Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_sequence_option Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_sequence_option/it/ (cherry picked from commit 7eb5f5d)
(cherry picked from commit 0b5c632)
(cherry picked from commit 35bf532)
dnplkndll
force-pushed
the
19.0-mig-hr_expense_sequence_option
branch
2 times, most recently
from
49bbd47 to
514a15f
Compare
BhaveshHeliconia
suggested changes
Jun 2, 2026
dnplkndll
force-pushed
the
19.0-mig-hr_expense_sequence_option
branch
from
514a15f to
82c5506
Compare
Author
|
thanks @BhaveshHeliconia updated |
BhaveshHeliconia
suggested changes
Jun 3, 2026
| @@ -1,2 +1,3 @@ | |||
| This module extends module ir_sequence_option and allow you to provide | |||
| optional sequences for hr.expense.sheet documents. | |||
| This module extends `base_sequence_option` and lets you provide optional | |||
Contributor
There was a problem hiding this comment.
These changes should go into the migration commit, not the pre-commit commit.
Comment on lines
+6
to
+15
| "summary": "Manage sequence options for hr.expense", | ||
| "version": "19.0.1.0.0", | ||
| "license": "AGPL-3", | ||
| "author": "Ecosoft, Odoo Community Association (OCA)", | ||
| "website": "https://github.com/OCA/hr-expense", | ||
| "category": "Human Resources", | ||
| "depends": ["base_sequence_option", "hr_expense_sequence"], | ||
| "demo": ["demo/hr_expense_demo_options.xml"], | ||
| "development_status": "Alpha", | ||
| "maintainers": ["ps-tubtim"], | ||
| "maintainers": ["ps-tubtim", "dnplkndll"], |
Contributor
There was a problem hiding this comment.
These changes should go into the migration commit, not the pre-commit commit.
dnplkndll
force-pushed
the
19.0-mig-hr_expense_sequence_option
branch
from
82c5506 to
ac13507
Compare
dnplkndll
force-pushed
the
19.0-mig-hr_expense_sequence_option
branch
3 times, most recently
from
32edb77 to
fc73317
Compare
hr.expense.sheet was removed in 19.0; retarget to hr.expense.
…nd hr_expense_sequence to open PRs
dnplkndll
force-pushed
the
19.0-mig-hr_expense_sequence_option
branch
from
fc73317 to
42a3845
Compare
BhaveshHeliconia
approved these changes
Jun 22, 2026
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
Contributor
There was a problem hiding this comment.
Code review LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of
hr_expense_sequence_optionfrom 18.0 to 19.0. Migration guide: https://github.com/OCA/maintainer-tools/wiki/#migration-to-version-19.0Depends on OCA/server-tools#3514 (
base_sequence_option19.0 MIG). The[DO NOT MERGE]commit at the tip of this branch pins that PR viatest-requirements.txtand will be stripped before final review.Non-mechanical adaptations worth flagging
_inherit = "hr.expense.sheet"→_inherit = "hr.expense". Their.sequence.option.line.get_sequence(self.new(vals))lookup increate()carries over verbatim; only the model on which it operates changed.hr.expense.sheet→hr.expense, with matchingondelete.ir.sequence.option.modelfield flips tohr.expense; demo sequence prefix wording updated ("Expense" not "Expense Sheet"/"Expense Report").hr.expense.create()directly and asserts the per-expense number. Split into two methods (option ON / option OFF) for clarity.