[19.0] [MIG] account_invoice_overdue_reminder: Migration to 19.0 by stferraro · Pull Request #560 · OCA/credit-control

stferraro · 2026-04-28T19:37:27Z

No description provided.

…instead of supplier invoice form

…update your mail templates) Add ability to add contacts as Cc of the reminder email (added to the Cc of the mail template) Add partner_policy with 3 options to give some choice about which contact should be selected to send reminders Access reminders from partner via Action menu

Advantages: 1) easy access to the history in the chatter of the partner. 2) no problem to access the email by other users (avoid "The requested operation cannot be completed due to security restrictions. Please contact your system administrator.")

Co-authored-by: ypapouin <y.papouin@dec-industrie.com>

…e customer invoices Move "Send overdue reminder" button to the alter banner.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: credit-control-14.0/credit-control-14.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-14-0/credit-control-14-0-account_invoice_overdue_reminder/

Currently translated at 98.9% (185 of 187 strings) Translation: credit-control-14.0/credit-control-14.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-14-0/credit-control-14-0-account_invoice_overdue_reminder/fr/

… date

…mail vals generation

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: credit-control-18.0/credit-control-18.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-18-0/credit-control-18-0-account_invoice_overdue_reminder/

Currently translated at 100.0% (185 of 185 strings) Translation: credit-control-18.0/credit-control-18.0-account_invoice_overdue_reminder Translate-URL: https://translation.odoo-community.org/projects/credit-control-18-0/credit-control-18-0-account_invoice_overdue_reminder/it/

stferraro · 2026-04-28T19:38:00Z

@OCA credit-control/manteiners ping .

rrebollo · 2026-04-29T18:56:25Z

@stferraro the migration should be done in a single commit. I'm referring strictly to the migration to version 19.0—you may have a pre-commit solving commit prior to that (still in 18.0), but you shouldn't have multiple commits for the migration itself (apart from that ones from git history, (work till 18.0).

rrebollo

These are the suggestions made in #523. Please also review the Migration to version 19.0 guide for the v19 specifications.

Additionally, during the migration to v18, the tests were removed. I strongly encourage bringing them back. You can look at the v17 tests and adapt them to v19.

rrebollo · 2026-04-29T18:57:39Z

+    # Because of the "counter" field: a single reminder action for a customer,
+    # the "counter" may not be the same for each invoice
+    invoice_id = fields.Many2one(
+        "account.move", string="Invoice", ondelete="cascade", readonly=True


Suggested change

"account.move", string="Invoice", ondelete="cascade", readonly=True

"account.move", string="Invoice", ondelete="cascade"

Consider OCA's Guidelines for migration to v17 comments on this topic:

If a field is marked as readonly=True on the model, it won't be possible to import it through the Odoo import tool, so avoid it as possible and define the readonly attribute on the views instead.

rrebollo · 2026-04-29T18:58:20Z

+    action_result_notes = fields.Html(related="action_id.result_notes", readonly=False)
+    action_mail_id = fields.Many2one(related="action_id.mail_id")
+    action_mail_cc = fields.Char(
+        related="action_id.mail_id.email_cc", readonly=True, string="Cc"


Suggested change

related="action_id.mail_id.email_cc", readonly=True, string="Cc"

related="action_id.mail_id.email_cc", string="Cc"

This is default behavior

rrebollo · 2026-04-29T18:58:45Z

+    action_mail_state = fields.Selection(
+        related="action_id.mail_id.state", string="E-mail Status"
+    )
+    counter = fields.Integer(readonly=True)


Suggested change

counter = fields.Integer(readonly=True)

counter = fields.Integer()

See above comment on this topic

rrebollo · 2026-04-29T19:00:00Z

+            if action.invoice_id and action.invoice_id.move_type not in [
+                "out_invoice",
+                "out_refund",
+            ]:


Suggested change

if action.invoice_id and action.invoice_id.move_type not in [

"out_invoice",

"out_refund",

]:

if action.invoice_id and not action.invoice_id.is_sale_document():

rrebollo · 2026-04-29T19:00:39Z

+                "out_refund",
+            ]:
+                raise ValidationError(
+                    self.envv._(


Suggested change

self.envv._(

self.env._(

Hi @rrebollo, thanks for your contribution and help. I'm going to correct these codes. Stay tuned for any further corrections.

rrebollo · 2026-04-29T19:19:04Z

+        return action
+
+    def skip(self):
+        self.write({"state": "skipped"})


Suggested change

self.write({"state": "skipped"})

self.state = "skipped"

rrebollo · 2026-04-29T19:19:46Z

+            orao.create(vals)
+            if rec.create_activity:
+                mao.create(self._prepare_mail_activity())
+        self.write({"state": "done"})


Suggested change

self.write({"state": "done"})

self.state = "done"

rrebollo · 2026-04-29T19:21:22Z

+        mail = self.env["mail.mail"].sudo().create(mvals)
+        if self.company_id.overdue_reminder_attach_invoice:
+            attachment_ids = self._get_attachment_ids(mail)
+            mail.write({"attachment_ids": [Command.set(attachment_ids)]})


Suggested change

mail.write({"attachment_ids": [Command.set(attachment_ids)]})

mail.attachment_ids = [Command.set(attachment_ids)]

rrebollo · 2026-04-29T19:22:40Z

+
+    def print_letter(self):
+        self.check_warnings()
+        self.write({"letter_printed": True})


Suggested change

self.write({"letter_printed": True})

self.letter_printed = True

rrebollo · 2026-04-29T19:23:31Z

+        elif self.update_action == "reminder_type":
+            if not self.reminder_type:
+                raise UserError(self.env._("You must select the new reminder type."))
+            actions.write({"reminder_type": self.reminder_type})


Suggested change

actions.write({"reminder_type": self.reminder_type})

actions.reminder_type = self.reminder_type

rrebollo · 2026-05-04T18:47:38Z

@stferraro what about bringing back the tests adapted from v17?

stferraro · 2026-05-04T23:47:44Z

Hi, @rrebollo Sure, I’ll bring back the tests adapted from v17 and update them accordingly for v19.0 to ensure proper coverage., @rrebollo

rrebollo

Code Review. LGTM!

stferraro · 2026-05-05T15:38:39Z

Hi, @alexis-via please check this PR and approve

Yusuke1998

LGTM!

OCA-git-bot · 2026-05-07T16:53:35Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Karla-Villegas

Approved!

OCA-git-bot · 2026-05-22T22:46:00Z

Hi @stferraro. Your command failed:

Invalid command: ping.

Ocabot commands

ocabot merge major|minor|patch|nobump
ocabot rebase
ocabot migration {MODULE_NAME}

More information

ocabot documentation
OCA guidelines, specially the "Version Numbers" section.

AnizR

Thanks for your work !
I have some nit picking regarding the 'translation' of fields (I see that it has already been flagged).

AnizR · 2026-06-04T18:51:28Z

+            ("mail", self.env._("E-mail")),
+            ("phone", self.env._("Phone")),
+            ("post", self.env._("Letter")),


AnizR · 2026-06-04T18:51:55Z

+            ("onebyone", self.env._("One by One")),
+            ("mass", self.env._("Mass")),


AnizR · 2026-06-04T18:52:16Z

+            ("last_reminder", self.env._("Last Reminder")),
+            ("last_invoice", self.env._("Last Invoice")),
+            ("invoice_contact", self.env._("Invoice Contact")),


stferraro · 2026-06-05T13:09:53Z

Thanks for the review and the positive feedback, @AnizR! Highly appreciate it. 🙏

alexis-via and others added 30 commits April 28, 2026 14:05

Add module account_invoice_overdue_reminder

0cf352b

Switch row and col in pivot view of overdue reminders

9502892

overdue_reminder: explicit error when email is missing

bbeac27

[FIX] overdue_reminder: don't link mail.template to a wizard record !

b1abee8

overdue_reminder: use form_view_ref to display customer invoice form …

5b717ee

…instead of supplier invoice form

Add migration script for my previous commit

7f03f0f

Improve string and fix translation of selection field

b7ef903

Co-authored-by: ypapouin <y.papouin@dec-industrie.com>

Fix translation of selection field

f35fd62

Co-authored-by: ypapouin <y.papouin@dec-industrie.com>

[MIG] account_invoice_overdue_reminder to v14.0

aca8211

account_invoice_overdue_reminder: black, isort and other reformatting

ceade90

[UPD] Update account_invoice_overdue_reminder.pot

661f749

[UPD] README.rst

1c7ed83

[ADD] icon.png

fcdfc18

Added translation using Weblate (Italian)

28442e9

[IMP] account_invoice_overdue_reminder: yellow alter banner on overdu…

0f82131

…e customer invoices Move "Send overdue reminder" button to the alter banner.

[UPD] Update account_invoice_overdue_reminder.pot

19fcb11

account_invoice_overdue_reminder 14.0.1.1.0

bef3e26

[FIX] account_invoice_overdue_reminder: bad string

bc0d921

[UPD] Update account_invoice_overdue_reminder.pot

b009a8e

Added translation using Weblate (Catalan)

2fb2a84

Added translation using Weblate (French)

f0df4cf

[IMP]account_invoice_overdue_reminder: Set default values

1feb93f

account_invoice_overdue_reminder 14.0.1.1.1

a06f078

[FIX] account_invoice_overdue_reminder: prevent error when no overdue…

67afea3

… date

[IMP] account_invoice_overdue_reminder: decouple mail validation and …

bd832d6

…mail vals generation

oca-ci and others added 4 commits April 28, 2026 14:05

[UPD] Update account_invoice_overdue_reminder.pot

c5c88f6

[BOT] post-merge updates

9dc67a9

OCA-git-bot added series:19.0 mod:account_invoice_overdue_reminder Module account_invoice_overdue_reminder labels Apr 28, 2026

stferraro mentioned this pull request Apr 29, 2026

Migration to version 19.0 #510

Open

13 tasks

rrebollo suggested changes Apr 29, 2026

View reviewed changes

stferraro changed the title ~~19.0 mig account invoice overdue reminder~~ [19.0] [MIG] account_invoice_overdue_reminder: Migration to 19.0 Apr 29, 2026

stferraro force-pushed the 19.0-mig-account_invoice_overdue_reminder branch from c564ccd to 82f9afa Compare April 30, 2026 00:06

stferraro requested a review from rrebollo April 30, 2026 00:16

stferraro force-pushed the 19.0-mig-account_invoice_overdue_reminder branch 2 times, most recently from bccc792 to b49ef71 Compare May 5, 2026 00:31

[MIG] account_invoice_overdue_reminder: Migration to 19.0

de5e2d9

stferraro force-pushed the 19.0-mig-account_invoice_overdue_reminder branch from b49ef71 to de5e2d9 Compare May 5, 2026 00:35

rrebollo approved these changes May 5, 2026

View reviewed changes

Yusuke1998 approved these changes May 7, 2026

View reviewed changes

OCA-git-bot added approved ready to merge labels May 7, 2026

Karla-Villegas approved these changes May 18, 2026

View reviewed changes

AnizR approved these changes Jun 4, 2026

View reviewed changes

samirGuesmi mentioned this pull request Jul 8, 2026

[19.0][IMP] account_invoice_overdue_reminder: Add a config and a hook to sort moves using partner or residual amount #569

Open

	"account.move", string="Invoice", ondelete="cascade", readonly=True
	"account.move", string="Invoice", ondelete="cascade"

	related="action_id.mail_id.email_cc", readonly=True, string="Cc"
	related="action_id.mail_id.email_cc", string="Cc"

	counter = fields.Integer(readonly=True)
	counter = fields.Integer()

	mail.write({"attachment_ids": [Command.set(attachment_ids)]})
	mail.attachment_ids = [Command.set(attachment_ids)]

	self.write({"letter_printed": True})
	self.letter_printed = True

	actions.write({"reminder_type": self.reminder_type})
	actions.reminder_type = self.reminder_type

		("onebyone", self.env._("One by One")),
		("mass", self.env._("Mass")),

Uh oh!

Uh oh!

Conversation

stferraro commented Apr 28, 2026

Uh oh!

stferraro commented Apr 28, 2026

Uh oh!

rrebollo commented Apr 29, 2026

Uh oh!

rrebollo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rrebollo commented May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stferraro commented May 4, 2026

Uh oh!

rrebollo left a comment

Choose a reason for hiding this comment

Uh oh!

stferraro commented May 5, 2026

Uh oh!

Yusuke1998 left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented May 7, 2026

Uh oh!

Karla-Villegas left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented May 22, 2026

Uh oh!

AnizR left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stferraro commented Jun 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

rrebollo commented May 4, 2026 •

edited

Loading