Rename fields in structs that use names which are reserved in c++ - #57
Merged
Conversation
tomaszklak
force-pushed
the
rename-reserved-cpp-field-names
branch
from
October 14, 2025 14:00
071f128 to
fa81ce4
Compare
macos-13 will be removed before the end of the year. Signed-off-by: Tomasz Kłak <tomasz.klak@nordsec.com>
Signed-off-by: Tomasz Kłak <tomasz.klak@nordsec.com>
tomaszklak
force-pushed
the
rename-reserved-cpp-field-names
branch
from
October 14, 2025 14:08
fa81ce4 to
09725c5
Compare
tomaszklak
changed the title
Lipt0nas
approved these changes
Oct 15, 2025
Lipt0nas
left a comment
Lipt0nas
left a comment
Member
There was a problem hiding this comment.
Looks good, just needs the changelog and cargo version bump and we're good to go
|
+1 |
Signed-off-by: Tomasz Kłak <tomasz.klak@nordsec.com>
tomaszklak
force-pushed
the
rename-reserved-cpp-field-names
branch
from
October 15, 2025 08:02
09725c5 to
c9d08f0
Compare
Signed-off-by: Tomasz Kłak <tomasz.klak@nordsec.com>
tomaszklak
force-pushed
the
rename-reserved-cpp-field-names
branch
from
October 15, 2025 08:04
c9d08f0 to
39dff0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An example of such situation (which prompted this PR) can be found here: https://github.com/NordSecurity/libtelio/blob/9ad00837f0b429ec5c3278e42604856e7f861d60/src/libtelio.udl#L833