Update uniffi-rs to 0.29 - #56
Merged
Merged
Conversation
0Xellos
force-pushed
the
uniffi_v0.29
branch
from
September 28, 2025 19:38
1124768 to
807519a
Compare
Signed-off-by: Jakub Safin <jakub.safin@innovatrics.com>
0Xellos
force-pushed
the
uniffi_v0.29
branch
from
September 28, 2025 19:40
807519a to
75db7d9
Compare
Lipt0nas
reviewed
Oct 7, 2025
Lipt0nas
left a comment
Member
There was a problem hiding this comment.
The MR looks good overall, thank you for contributing!
Signed-off-by: Jakub Safin <jakub.safin@innovatrics.com> Co-authored-by: Martynas Gurskas <gurmart@gmail.com>
Lipt0nas
reviewed
Oct 31, 2025
|
@Lipt0nas Hello, do you plan to merge this update in the near future? Thanks a lot. |
Lipt0nas
approved these changes
Dec 11, 2025
Lipt0nas
left a comment
Member
There was a problem hiding this comment.
Everything looks in order, thanks for the patience and contribution 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes:
uniffi-rsversion to 0.29askama-> 0.13,cargo_metadata-> 0.19uniffi_bindgen::interface::Type::Externalsince this enum value got removeduniffi_bindgen::interface::FfiType::MutReference(identical toReference) since this enum value got addeddereftocpp_deref, it was causing conflict with a new builtin filteruniffi_bindgen::backend::TemplateExpressiontoStringsince this type got removedimpl CustomTypesConfig; changed the use ofinto_customandfrom_customincustom.cpptemplate toliftandlowerdefined hereStringto&striter_typestoiter_local_typesonComponentInterfacesince that method got removed - this is what I'm least confident about in this PR, there are multiple methods returning type iterators...fntofuncbecause of conflict with the Rust keywordget_*_definitionare used:ci|get_*_definition(name)->ci.get_*_definition(name).unwrap(){%- let ffi_converter_name = typ|ffi_converter_name|class_name %}inenum.hppanderr.hpptemplates into 2 steps, was required to passStringas&strfixturesto use macrouniffi::custom_newtypeDisclaimer: I'm a C++ guy, not a Rust guy. I was mostly going by a similar update that was done in
uniffi-bindgen-cs.