Register nat-lab log collector before client start steps - #1971
Merged
Conversation
A client that fails in start_named left no telio, system, or setupapi logs - registration happened only after the adapter came up, so the failures that most need device-side logs collected none. Signed-off-by: Gytis Stoškevičius <gytisstoskevicius@gmail.com>
gytsto
force-pushed
the
natlab-register-log-collector-early
branch
from
August 26, 2026 11:59
8865cb5 to
52c0464
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A client that fails during startup leaves no telio, system event, or setupapi logs in the test artifacts —
LogCollectoris registered only after the adapter is up, so exactly the failures that need device-side logs collect none.Solution
Register the collector right after the remote process is ready, before the start steps. Log fetching already tolerates a missing log file, and
LOG_COLLECTORSis cleared per test, so nothing double-collects.☑️ Definition of Done checklist