LLT-7637: natlab link detection test fails due to timeout - #1970
Merged
tomaszpatejko merged 1 commit intoAug 28, 2026
Merged
Conversation
tomaszpatejko
force-pushed
the
LLT-7637-natlab-link-detection-test-fails-due-to-timeout
branch
from
August 26, 2026 11:54
4cb9e45 to
f3d26d8
Compare
tomaszpatejko
changed the title
tomaszpatejko
force-pushed
the
LLT-7637-natlab-link-detection-test-fails-due-to-timeout
branch
from
August 27, 2026 05:05
f3d26d8 to
0041c6d
Compare
tomaszpatejko
force-pushed
the
LLT-7637-natlab-link-detection-test-fails-due-to-timeout
branch
from
August 27, 2026 16:19
0041c6d to
7514e9a
Compare
tomaszpatejko
force-pushed
the
LLT-7637-natlab-link-detection-test-fails-due-to-timeout
branch
from
August 27, 2026 18:10
7514e9a to
5dc618e
Compare
stalowyjez
previously approved these changes
Aug 28, 2026
Collaborator
|
+1 |
By default on Windows, ping has its wait time for reply set to 4000ms (4s). For natlab test test_event_link_state_peer_doesnt_respond, on Windows, that ping is sent every ~5s which colludes with session_keeper's ICMPv6 keepalive messages sent every 5s. If such collision happens then within wg's 1s polling window data is both sent and received. This in turn prevents BytesAndTimestamps::first_tx_after_rx to be set to Some. This variable is set to Some when within a polling window data is only sent and no data is received. Test test_event_link_state_peer_doesnt_respond waits for BytesAndTimestamps:: first_tx_after_rx to be set to Some. If that doesn't happen in 300s, Timeout exception is thrown and the test crashes. Fixes LLT-Fixes LLT-7637.
tomaszpatejko
force-pushed
the
LLT-7637-natlab-link-detection-test-fails-due-to-timeout
branch
from
August 28, 2026 12:44
5dc618e to
125c42b
Compare
stalowyjez
approved these changes
Aug 28, 2026
tomaszpatejko
deleted the
LLT-7637-natlab-link-detection-test-fails-due-to-timeout
branch
August 28, 2026 15:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
By default on Windows, ping has its wait time for reply set to 4000ms (4s). For natlab test
test_event_link_state_peer_doesnt_respond, on Windows, that ping is sent every ~5s which colludes with session_keeper's ICMPv6 keepalive messages sent every 5s.If such collision happens then within wg's 1s polling window data is both sent and received. This in turn prevents
BytesAndTimestamps::first_tx_after_rxto be set toSome. This variable is set toSomewhen within a polling window data is only sent and no data is received.Test
test_event_link_state_peer_doesnt_respondwaits forBytesAndTimestamps:: first_tx_after_rxto be set toSome. If that doesn't happen in 300s,Timeoutexception is thrown and the test crashes.Fixes LLT-Fixes LLT-7637.
Solution
Set ping wait for reply to 1s for Windows natlab tests.
☑️ Definition of Done checklist