Skip to content

Add support for SCrypt - #709

Open
bcantin wants to merge 1 commit into
NoamB:masterfrom
bcantin:master
Open

Add support for SCrypt#709
bcantin wants to merge 1 commit into
NoamB:masterfrom
bcantin:master

Conversation

@bcantin

@bcantin bcantin commented Aug 2, 2015

Copy link
Copy Markdown

No description provided.

@arnvald

arnvald commented Sep 18, 2015

Copy link
Copy Markdown
Collaborator

Hi @bcantin

thanks for the PR! I'll review the code next week and probably I'll ask some questions, since I haven't worked with SCrypt myself yet.

Also, could you change this code so that scrypt gem is loaded only when user chooses this algorithm? The reason is that I'm trying to make Sorcery work both on MRI and JRuby, and this gem provides native extension only for MRI, so loading it will fail on JRuby.

@bcantin

bcantin commented Sep 18, 2015

Copy link
Copy Markdown
Author

Sure thing. I'll do that later next week as I am visiting some family this
week

On Fri, 18 Sep 2015 at 12:32 Grzegorz Witek notifications@github.com
wrote:

Hi @bcantin https://github.com/bcantin

thanks for the PR! I'll review the code next week and probably I'll ask
some questions, since I haven't worked with SCrypt myself yet.

Also, could you change this code so that scrypt gem is loaded only when
user chooses this algorithm? The reason is that I'm trying to make Sorcery
work both on MRI and JRuby, and this gem provides native extension only for
MRI, so loading it will fail on JRuby.


Reply to this email directly or view it on GitHub
#709 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants