chore: add the workspace root manifest and align CI on pnpm 11 - #52
Merged
Conversation
Dependabot's npm updater aborts with `/package.json not found`. Pointed at the workspace root it needs a manifest there to anchor the pnpm workspace, and the migration never created one: the root carried only pnpm-workspace.yaml and the lockfile. So the npm ecosystem still could not update anything after the previous fix. Adds a minimal private root manifest with two targeted build scripts. No packageManager field on purpose: CI pins pnpm/action-setup to version 9, and that action errors when an explicit version and a packageManager field disagree. Adding one would trade this bug for a worse one.
johncarmack1984
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot's npm updater aborts with
/package.json not found. Pointed at the workspace root it needs a manifest there to anchor the pnpm workspace, and the migration never created one: the root had onlypnpm-workspace.yamland the lockfile. So the npm ecosystem still could not update anything after the previous fix.Adds a minimal private root manifest with two targeted build scripts.
pnpm version, one source of truth
CI pinned
pnpm/action-setuptoversion: 9in five places while local development ran pnpm 11. The lockfile happened to read fine under both, which is why nothing had broken yet, but the two were free to drift.packageManager: "pnpm@11.17.0"now lives in the root manifest and the explicitversion: 9pins are removed from all five call sites (ci.yml,ci-www.yml,deploy-www.yml,release.yml, and thesetup-rustcomposite action).pnpm/action-setupreadspackageManagerwhen no version is given, so CI and local move together from here.CI on this PR is the verification: every job installs through
action-setupwith no version pin.