Add opt-in per-submission-mode breakdown for user metrics - #1259
Merged
Conversation
bhou2
force-pushed
the
user-metrics-split-by-mode
branch
from
July 10, 2026 07:39
3ecf5e6 to
1be4cd5
Compare
bhou2
force-pushed
the
user-metrics-split-by-mode
branch
from
July 11, 2026 00:00
1be4cd5 to
6f26fad
Compare
bhou2
force-pushed
the
user-metrics-split-by-mode
branch
from
July 13, 2026 17:28
6f26fad to
1ae871b
Compare
bhou2
marked this pull request as ready for review
July 13, 2026 17:52
bhou2
force-pushed
the
user-metrics-split-by-mode
branch
from
July 13, 2026 17:58
1ae871b to
1d24cd5
Compare
zdong2
approved these changes
Jul 13, 2026
zdong2
left a comment
zdong2
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Thanks for adding it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce an opt-in
genie.tasks.user-metrics.split-by-submission-modeflag that, when enabled, additionally publishes per-user active-jobs and active-memory gauges broken down by job submission mode (submissionMode=api for REST API vs submissionMode=agent for agent/CLI) under newgenie.user.active-jobs.by-submission-mode.gauge/genie.user.active-memory.by-submission-mode.gaugemetric names.Unit and Integration Tests:
Dev Tests:
New metric [both api mode and agent mode included]:
Legacy metric [only api mode included]: