feat: enhance InfrastructureHealth tool#4315
Open
rahulguptajss wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the infrastructure_health MCP tool to provide broader ONTAP health coverage and improved query filtering, so users can get a more complete operational snapshot (optionally scoped to a cluster/cluster regex).
Changes:
- Expanded
InfrastructureHealthhealth check set to include hardware/environmental, aggregate space, SnapMirror lag, network errors, licensing, SAN, and subsystem/SVM checks. - Improved cluster label injection to support PromQL selectors that already include labels (e.g.,
metric{...}). - Extended “details” output by extracting additional identifiers (svm/disk/shelf/lif/lun/etc.) and updated the tool description to match the new coverage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
mcp/cmd/server/main.go |
Adds additional health checks/metric context, improves cluster filter injection for metric{...} queries, and expands identifier extraction for details output. |
mcp/cmd/descriptions/descriptions.go |
Updates the infrastructure_health tool description to reflect the expanded checks and metric semantics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cgrinds
reviewed
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.