feat: cmperf collector#4305
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces the CmPerf collector's data path: instead of polling per-counter REST endpoints, it downloads pre-aggregated CM2 protobuf files from the ONTAP counter-cache SPI endpoint, parses them into the matrix, and cooks counters using the existing RestPerf-style post-processing. Templates under conf/cmperf/9.19.1 are migrated from the old instance_key: + plain counter style to the new ^^/^ counter-prefix syntax that CmPerf's InitCache requires. A small IsCmPerfCollector() hook is added so the RestPerf NIC plugin selects the rx_bytes/tx_bytes naming used by CmPerf.
Changes:
- New
cm2.go: ONTAP file listing, SPI download, protobuf parse, schema-driven counter setup, scalar/1D/2D/histogram matrix population, and instance-key construction. - Reworked
cmperf.goPollData/PollCounter to drive the CM2 download/parse pipeline, plus receiver-name and structural cleanups (drop unused QoS-detail plumbing andInitSchedule). - Bulk template migration to
^^instance_uuid/^…label syntax across 30+ object YAMLs, and small plugin/poller hooks (IsCmPerfCollector, NIC plugin updates).
Reviewed changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/collectors/cmperf/cm2.go | New CM2 download/parse pipeline and matrix population. |
| cmd/collectors/cmperf/cmperf.go | Reworked PollData/PollCounter around CM2 files; receiver rename; QoS-detail cleanup. |
| cmd/poller/plugin/plugin.go | Adds IsCmPerfCollector() helper. |
| cmd/collectors/restperf/plugins/nic/nic.go | Treats CmPerf like StatPerf for rx/tx byte naming and nic port label. |
| conf/cmperf/9.19.1/*.yaml (30+) | Migrate counters to ^^/^ prefix syntax; drop top-level instance_key; minor formatting. |
| conf/cmperf/9.19.1/token_manager.yaml | Renames instance_name => token but is missing the ^/^^ prefixes, leaving the template inconsistent with the rest of the migration. |
| conf/cmperf/9.19.1/workload*.yaml | Switch keys to ^^instance_uuid, change data schedule from 3m to 1m. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cgrinds
reviewed
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.