Skip to content

Remove ToullligQC and rsync to HPC for ONT data on preproc - #516

Merged
ssjunnebo merged 5 commits into
NationalGenomicsInfrastructure:masterfrom
ssjunnebo:prom_rsync_fix
Nov 3, 2026
Merged

ssjunnebo merged 5 commits into
NationalGenomicsInfrastructure:masterfrom
ssjunnebo:prom_rsync_fix

Conversation

@ssjunnebo

@ssjunnebo ssjunnebo commented Nov 2, 2026 •

Copy link
Copy Markdown

ToulligQC is included in Seqinspector and we can start testing it out on Miarka. Since we no longer run ToulligQC on the preproc, there is nothing to sync from the preproc that hasn't already been synced from the promethion. Since the rsync is currently failing due to the updated rsync version on Miarka, we decided to remove the rsync and running of ToulligQC from TACA.

@ssjunnebo
ssjunnebo requested review from FranBonath and aanil November 2, 2026 09:19
@codecov

codecov Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.43%. Comparing base (167e36d) to head (1e749f9).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
taca/analysis/cli.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
- Coverage   26.15%   25.43%   -0.73%     
==========================================
  Files          37       37              
  Lines        5590     5450     -140     
==========================================
- Hits         1462     1386      -76     
+ Misses       4128     4064      -64     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@ssjunnebo ssjunnebo changed the title Make sure empty string in destination is not None Remove ToullligQC and rsync to HPC for ONT data on preproc Nov 2, 2026
@ssjunnebo
ssjunnebo requested a review from alneberg November 2, 2026 10:59

@aanil aanil left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ssjunnebo
ssjunnebo merged commit 60187f0 into NationalGenomicsInfrastructure:master Nov 3, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants