chore: standardize license header tooling - #405
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThe build configuration installs the configured Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@agent/go/deps.mk`:
- Around line 50-52: Update the addlicense target to validate the existing
$(ADDLICENSE) against ADDLICENSE_VERSION before reuse, rather than only checking
that it is non-empty. Require an executable file and add a version stamp or
supported-version check tied to ADDLICENSE_VERSION; reinstall when validation
fails.
In `@agent/go/Makefile`:
- Around line 54-56: Update the license validation pipeline in the wrong-file
check to match SPDX-License-Identifier: Apache-2.0 only within the leading
header comment block, rather than anywhere in the first 20 lines. Preserve the
generated-file exemption and report files whose header lacks the exact Apache
identifier.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 8cf9b208-cd62-4c26-bf9a-a03989a4552c
📒 Files selected for processing (2)
agent/go/Makefileagent/go/deps.mk
e9d1c9a to
592a774
Compare
592a774 to
804039e
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/lint-ci.yaml:
- Line 54: Update the actions/setup-go step to reference the reviewed commit SHA
instead of the mutable v7 tag, while retaining the existing version comment.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 0fd27ae0-3f4b-486c-a7ba-3d66148e0473
📒 Files selected for processing (7)
.github/workflows/agent-go-ci.yaml.github/workflows/lint-ci.yamlMakefileagent/Makefileagent/go/Makefileagent/go/deps.mkoperator/Makefile
Signed-off-by: Riley Rice <rrice@nvidia.com>
804039e to
7255625
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Description
Standardizes Apache-2.0 source-header formatting and validation with google/addlicense while preserving component ownership.
format_license.pyimplementation.Third-party dependency license allowlisting is intentionally out of scope and will be handled in a separate PR.
Part of #219
Validation
make license-fmtmake license-header-checkmake unit-tests(agent/go)make vet(agent/go)make lint(agent/go)make build(agent/go)yamllint -c ci/yamllint.yaml .github/workflows/lint-ci.yaml .github/workflows/agent-go-ci.yamlChecklist
git commit -s) per the DCO.