Repository navigation
chore(core): remove redundant control type assertion - #401
Merged
Merged
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
coryrylan
approved these changes
Oct 11, 2026
coryrylan
marked this pull request as ready for review
October 11, 2026 16:28
Removes an unnecessary assertion from the control reset path and prunes its ESLint suppression. Runtime behavior and the public API remain unchanged. Signed-off-by: Cursor Agent <cursoragent@cursor.com>
coryrylan
force-pushed
the
topic/upkeep/lint/control-type-assertion
branch
from
October 11, 2026 16:29
ecf825b to
841e09c
Compare
coryrylan
enabled auto-merge (rebase)
October 11, 2026 16:29
Collaborator
|
🎉 This issue has been resolved in version 2.15.2 🎉 |
Collaborator
|
🎉 This issue has been resolved in version 1.0.0 🎉 |
Collaborator
|
🎉 This issue has been resolved in version 2.7.3 🎉 |
Collaborator
|
🎉 This issue has been resolved in version 1.2.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Control.reset()and pruned its suppression: 222 → 221 repository-wide.Validation: core lint, unit (2,379 tests), types, axe, SSR, Lighthouse (81 tests), visual, final full repository CI, and
git diff --checkall passed.