Repository navigation
chore(starters): update solid-js to 1.9.17 - #395
Merged
Merged
Conversation
Signed-off-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Cory Rylan <coryrylan@users.noreply.github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
coryrylan
approved these changes
Oct 9, 2026
Collaborator
|
🎉 This issue has been resolved in version 2.0.8 🎉 |
Collaborator
|
🎉 This issue has been resolved in version 2.15.0 🎉 |
Collaborator
|
🎉 This issue has been resolved in version 2.7.2 🎉 |
Collaborator
|
🎉 This issue has been resolved in version 1.1.0 🎉 |
Collaborator
|
🎉 This issue has been resolved in version 2.1.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the Solid starter runtime dependency
solid-jsfrom 1.9.16 to 1.9.17.solid-jsis a runtime dependency, pinned exactly inprojects/starters/solidjs/package.jsondependencies. The starter is private and unpublished, so this is achore(starters)change.vite-plugin-solid(solid-js^1.7.2) andsolid-devtools(solid-js^1.9.0) already accept 1.9.17, so they stay on their current versions.Release review: 1.9.17 was published on 2026-10-07 and is outside the 1140-minute release-age window. The patch updates bundled DOM Expressions from 0.40.11 to 0.40.12. Server rendering drops spread keys the HTML parser would treat as more than one name, throws for an invalid dynamic tag name (matching client
document.createElement), and escapes class and style names. Output for valid names is unchanged. License stays MIT. Dependencies stayserovalandseroval-plugins~1.6.8. No engine, peer, install, or migration change.Generated changes are limited to
pnpm-lock.yaml: the Solid starter pin and integrity, plus peer snapshot keys that referencesolid-js. No other direct dependency moved.node ./projects/internals/ci/notice/index.jsleft everyNOTICE.mdunchanged.pnpm run noticeis not a root script.Validation:
mise exec -- pnpm run ciinprojects/starters/solidjs: passed (24 scripts, 30.2s)mise exec -- node .agents/skills/agent-dependencies/scripts/verify-update.js --type=chore --scope=starters: verifiedCI=1 mise exec -- pnpm install --frozen-lockfile: passedmise exec -- pnpm run cifrom the repository root: passed (152 scripts, 24 skipped, 127.2s)git diff --check: passedThe Angular 22.2 family was not included. Framework packages are eligible only through 22.2.1, while aligning
@angular/cliand@angular/buildcrosses the 22.2.0 toolchain change that previously rewrote peer snapshots outside the starter.