Skip to content

Repository navigation

feat(media): picture in picture button #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coryrylan merged 4 commits into from
Oct 13, 2026
+1,029 −24
Merged

feat(media): picture in picture button #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
407f124
fix(core): add pip i18n strings
coryrylan Oct 6, 2026
8c3c984
feat(media): picture in picture button
coryrylan Oct 6, 2026
584f1e3
fix(lint): add invoker trigger element reference
coryrylan Oct 6, 2026
b998123
chore(core): update lighthouse
coryrylan Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/core/src/internal/controllers/i18n.controller.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,9 @@ describe('i18n.controller', () => {
enableLoop: 'enable looping',
disableLoop: 'disable looping',
enterFullscreen: 'enter full screen',
enterPip: 'enter picture in picture',
exitFullscreen: 'exit full screen',
exitPip: 'exit picture in picture',
muteMedia: 'mute media',
pauseMedia: 'pause media',
playMedia: 'play media',
Expand Down Expand Up @@ -152,7 +154,9 @@ describe('i18n.controller', () => {
enableLoop: 'enable looping',
disableLoop: 'disable looping',
enterFullscreen: 'enter full screen',
enterPip: 'enter picture in picture',
exitFullscreen: 'exit full screen',
exitPip: 'exit picture in picture',
muteMedia: 'mute media',
pauseMedia: 'pause media',
playMedia: 'play media',
Expand Down
2 changes: 2 additions & 0 deletions projects/core/src/internal/services/i18n.service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,9 @@ describe('I18nService', () => {
enableLoop: 'enable looping',
disableLoop: 'disable looping',
enterFullscreen: 'enter full screen',
enterPip: 'enter picture in picture',
exitFullscreen: 'exit full screen',
exitPip: 'exit picture in picture',
muteMedia: 'mute media',
pauseMedia: 'pause media',
playMedia: 'play media',
Expand Down
4 changes: 4 additions & 0 deletions projects/core/src/internal/services/i18n.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@ export interface I18nStrings {
enableLoop: string;
disableLoop: string;
enterFullscreen: string;
enterPip: string;
exitFullscreen: string;
exitPip: string;
muteMedia: string;
pauseMedia: string;
playMedia: string;
Expand Down Expand Up @@ -101,7 +103,9 @@ const i18nRegistry = {
enableLoop: 'enable looping',
disableLoop: 'disable looping',
enterFullscreen: 'enter full screen',
enterPip: 'enter picture in picture',
exitFullscreen: 'exit full screen',
exitPip: 'exit picture in picture',
muteMedia: 'mute media',
pauseMedia: 'pause media',
playMedia: 'play media',
Expand Down
2 changes: 1 addition & 1 deletion projects/core/src/star-rating/star-rating.test.lighthouse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@ describe('star-rating lighthouse report', () => {
expect(report.scores.performance).toBe(100);
expect(report.scores.accessibility).toBe(100);
expect(report.scores.bestPractices).toBe(100);
expect(report.payload.javascript.kb).toBeLessThan(22.4);
expect(report.payload.javascript.kb).toBeLessThan(22.5);
});
});
3 changes: 1 addition & 2 deletions projects/core/src/tree/tree.test.lighthouse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ describe('tree lighthouse report', () => {
expect(report.scores.performance).toBe(100);
expect(report.scores.accessibility).toBe(100);
expect(report.scores.bestPractices).toBe(100);
// Allow a small margin above measured local and CI payloads.
expect(report.payload.javascript.kb).toBeLessThanOrEqual(30.6);
expect(report.payload.javascript.kb).toBeLessThan(30.7);
Comment thread
coryrylan marked this conversation as resolved.
});
});
9 changes: 6 additions & 3 deletions projects/lint/src/eslint/rules/no-invalid-invoker-triggers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import noInvalidInvokerTriggers from './no-invalid-invoker-triggers.js';
const rule = noInvalidInvokerTriggers as unknown as JSRuleDefinition;

const validElements =
'nve-button, nve-icon-button, nve-menu-item, nve-sort-button, nve-tabs-item, nve-tag, nve-steps-item, nve-copy-button, nve-media-fullscreen-button, nve-media-loop-button, nve-media-mute-button, nve-media-pause-button, nve-media-seek-button';
'nve-button, nve-icon-button, nve-menu-item, nve-sort-button, nve-tabs-item, nve-tag, nve-steps-item, nve-copy-button, nve-media-fullscreen-button, nve-media-loop-button, nve-media-mute-button, nve-media-pause-button, nve-media-pip-button, nve-media-seek-button';

const commandElements = `${validElements}, nve-media-playback-rate-select, nve-media-time-range, nve-media-volume-range, nve-viewport-minimap, nve-viewport-zoom-range`;

Expand Down Expand Up @@ -53,7 +53,8 @@ describe('noInvalidInvokerTriggers', () => {
'<nve-tag popovertarget="my-popover">Tag</nve-tag>',
'<nve-steps-item popovertarget="my-popover">Step</nve-steps-item>',
'<nve-copy-button popovertarget="my-popover"></nve-copy-button>',
'<nve-media-fullscreen-button popovertarget="my-popover"></nve-media-fullscreen-button>'
'<nve-media-fullscreen-button popovertarget="my-popover"></nve-media-fullscreen-button>',
'<nve-media-pip-button popovertarget="my-popover"></nve-media-pip-button>'
],
invalid: []
});
Expand All @@ -66,6 +67,7 @@ describe('noInvalidInvokerTriggers', () => {
'<nve-icon-button commandfor="my-panel"></nve-icon-button>',
'<nve-tag commandfor="my-panel">Tag</nve-tag>',
'<nve-media-pause-button commandfor="my-player"></nve-media-pause-button>',
'<nve-media-pip-button commandfor="my-player"></nve-media-pip-button>',
'<nve-media-playback-rate-select commandfor="my-player"></nve-media-playback-rate-select>',
'<nve-media-mute-button commandfor="my-player"></nve-media-mute-button>',
'<nve-media-seek-button commandfor="my-player"></nve-media-seek-button>',
Expand All @@ -84,7 +86,8 @@ describe('noInvalidInvokerTriggers', () => {
tester.run('interestfor on button-type elements', rule, {
valid: [
'<nve-button interestfor="my-tooltip">Hover</nve-button>',
'<nve-icon-button interestfor="my-tooltip"></nve-icon-button>'
'<nve-icon-button interestfor="my-tooltip"></nve-icon-button>',
'<nve-media-pip-button interestfor="my-tooltip"></nve-media-pip-button>'
],
invalid: []
});
Expand Down
1 change: 1 addition & 0 deletions projects/lint/src/eslint/rules/no-invalid-invoker-triggers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ const BUTTON_TYPE_ELEMENTS = [
'nve-media-loop-button',
'nve-media-mute-button',
'nve-media-pause-button',
'nve-media-pip-button',
'nve-media-seek-button'
] as const;

Expand Down
3 changes: 3 additions & 0 deletions projects/media/.visual/media-pip-button.dark.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions projects/media/.visual/media-pip-button.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 12 additions & 0 deletions projects/media/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,18 @@
"types": "./dist/pause-button/index.d.ts",
"default": "./dist/pause-button/index.js"
},
"./pip-button": {
"types": "./dist/pip-button/index.d.ts",
"default": "./dist/pip-button/index.js"
},
"./pip-button/define.js": {
"types": "./dist/pip-button/define.d.ts",
"default": "./dist/pip-button/define.js"
},
"./pip-button/index.js": {
"types": "./dist/pip-button/index.d.ts",
"default": "./dist/pip-button/index.js"
},
"./playback-rate-select": {
"types": "./dist/playback-rate-select/index.d.ts",
"default": "./dist/playback-rate-select/index.js"
Expand Down
1 change: 1 addition & 0 deletions projects/media/src/controller/controller.examples.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ export const Default = {
<nve-media-volume-range commandfor="example-media" name="volume" style="max-width: 100px"></nve-media-volume-range>
<nve-media-playback-rate-select commandfor="example-media" name="playbackRate"></nve-media-playback-rate-select>
<nve-media-loop-button commandfor="example-media"></nve-media-loop-button>
<nve-media-pip-button commandfor="example-media"></nve-media-pip-button>
<nve-media-fullscreen-button commandfor="example-media"></nve-media-fullscreen-button>
</div>
</div>
Expand Down
Loading
Loading