fix(recipe): align AKS inference K8s floors with DRA-GA >= 1.34 rationale - #1984
fix(recipe): align AKS inference K8s floors with DRA-GA >= 1.34 rationale#1984mohityadav8 wants to merge 2 commits into
Conversation
…nale Bumps aks-inference, h100-aks-inference, and h100-aks-ubuntu-inference from >= 1.30 / >= 1.32.4 to >= 1.34, matching the DRA-GA rationale already stated in aks.yaml and mirroring the training-family fix (NVIDIA#1908). h100-aks-ubuntu-inference-dynamo was already correct. Extends TestH100AKSUbuntuTrainingSlurmFloorNotClobbered with the inference-family leaf cases. Fixes: NVIDIA#1969
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe three AKS inference overlays now require Kubernetes Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Recipe evidence checkProtected recipesRecipes with committed evidence (
Other affected recipes without evidence yet: 2These recipes are affected by this PR but carry no committed evidence pointer, so there is
How to refresh evidenceRun on a cluster matching the recipe's aicr snapshot -o snapshot.yaml
# Profiled families (AKS gpuStack): capture the pool projection and
# hydrate the recipe with the pointer's recorded 'profile:' selection
# first — validating the raw overlay resolves only the declaration
# default, and 'aicr validate' has no --profile flag:
# az aks nodepool list -g <rg> --cluster-name <cluster> -o json > pools.json
# aicr snapshot --aks-gpu-pools pools.json -o snapshot.yaml
# aicr recipe -s snapshot.yaml --intent <intent> [--platform <platform>] \
# --profile <name>=<value> -o recipe.yaml
# State the target leaf's intent/platform explicitly (the snapshot
# fingerprint supplies service/accelerator/OS but intent and platform
# default to 'any') and pass -r recipe.yaml below instead of the raw
# overlay.
aicr validate \
-r recipes/overlays/<slug>.yaml \
-s snapshot.yaml \
--emit-attestation ./out \
--push ghcr.io/<your-fork>/aicr-evidence
# Copy to the per-source path printed in the emit 'copyTo' hint:
# recipes/evidence/<slug>/<source>/<bundle-digest>.yamlThis gate is warning-only and never blocks merge. See ADR-007 for the trust model. |
Bumps aks-inference, h100-aks-inference, and h100-aks-ubuntu-inference from >= 1.30 / >= 1.32.4 to >= 1.34, matching the DRA-GA rationale already stated in aks.yaml and mirroring the training-family fix (#1908). h100-aks-ubuntu-inference-dynamo was already correct.
Extends TestH100AKSUbuntuTrainingSlurmFloorNotClobbered with the inference-family leaf cases.
Fixes: #1969