Skip to content

fix(recipe): align AKS inference K8s floors with DRA-GA >= 1.34 rationale - #1984

Open
mohityadav8 wants to merge 2 commits into
NVIDIA:mainfrom
mohityadav8:fix/issue-1969-aks-inference-k8s-floor
Open

fix(recipe): align AKS inference K8s floors with DRA-GA >= 1.34 rationale#1984
mohityadav8 wants to merge 2 commits into
NVIDIA:mainfrom
mohityadav8:fix/issue-1969-aks-inference-k8s-floor

Conversation

@mohityadav8

Copy link
Copy Markdown
Contributor

Bumps aks-inference, h100-aks-inference, and h100-aks-ubuntu-inference from >= 1.30 / >= 1.32.4 to >= 1.34, matching the DRA-GA rationale already stated in aks.yaml and mirroring the training-family fix (#1908). h100-aks-ubuntu-inference-dynamo was already correct.

Extends TestH100AKSUbuntuTrainingSlurmFloorNotClobbered with the inference-family leaf cases.

Fixes: #1969

…nale

Bumps aks-inference, h100-aks-inference, and h100-aks-ubuntu-inference
from >= 1.30 / >= 1.32.4 to >= 1.34, matching the DRA-GA rationale
already stated in aks.yaml and mirroring the training-family fix (NVIDIA#1908).
h100-aks-ubuntu-inference-dynamo was already correct.

Extends TestH100AKSUbuntuTrainingSlurmFloorNotClobbered with the
inference-family leaf cases.

Fixes: NVIDIA#1969
@mohityadav8
mohityadav8 requested review from a team as code owners August 2, 2026 10:20
@copy-pr-bot

copy-pr-bot Bot commented Aug 2, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: dc76c18b-6060-4c0c-9bd5-2e79d80431e8

📥 Commits

Reviewing files that changed from the base of the PR and between 0752ea1 and d3167ca.

📒 Files selected for processing (4)
  • pkg/recipe/metadata_store_test.go
  • recipes/overlays/aks-inference.yaml
  • recipes/overlays/h100-aks-inference.yaml
  • recipes/overlays/h100-aks-ubuntu-inference.yaml

📝 Walkthrough

Walkthrough

The three AKS inference overlays now require Kubernetes >= 1.34, with DRA rationale comments added where applicable. The metadata store regression test now covers generic AKS, H100 AKS, H100 Ubuntu AKS, and H100 Ubuntu Dynamo inference recipes. Each case checks both the resolved constraint and the leaf declaration.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: area/tests

Suggested reviewers: arangogutierrez

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the AKS inference Kubernetes floor update and its DRA-GA rationale.
Description check ✅ Passed The description accurately summarizes the recipe floor changes, regression test updates, and linked issue.
Linked Issues check ✅ Passed The changes satisfy issue #1969 by raising all three non-Dynamo inference floors, adding rationale comments, and extending regression coverage.
Out of Scope Changes check ✅ Passed The recipe updates and regression test changes are directly related to the objectives in issue #1969.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Recipe evidence check

Protected recipes

Recipes with committed evidence (recipes/evidence/<slug>/<source>/<digest>.yaml) that this PR affects: 1

Recipe Source Pointer Verify Digest match
h100-aks-ubuntu-inference-dynamo 5bf9e82f0e90a11528ac85f4bcb866c8 sha256-b7d3b1c672568329cae994ed4c831af5e569b23209fb81e789d2e2288b44100d ✅ passed ⚠️ stale (b0081437bf6d… vs current 4cdb994dd022…)
h100-aks-ubuntu-inference-dynamo 5bf9e82f0e90a11528ac85f4bcb866c8 sha256-ca96cea68b11cd3b5f0dbad677d40365287fce8e0a5412b32861888d335c5bdc ✅ passed ⚠️ stale (35e1d989567a… vs current 4cdb994dd022…)
h100-aks-ubuntu-inference-dynamo 5bf9e82f0e90a11528ac85f4bcb866c8 sha256-edc042d2e32d58bde9bb0e7cfdaa14568a13c144fdf0869958a4d582f3fc8cfc ✅ passed ⚠️ stale (ea8757f630ce… vs current 4cdb994dd022…)
h100-aks-ubuntu-inference-dynamo 5bf9e82f0e90a11528ac85f4bcb866c8 sha256-f8d2a0188274d179f37dfe39a257aeaa3fbb97273162586853e0986bfa5d3c05 ✅ passed ⚠️ stale (8e88ca57dea5… vs current 4cdb994dd022…)
Other affected recipes without evidence yet: 2

These recipes are affected by this PR but carry no committed evidence pointer, so there is
nothing to verify. This is expected — evidence is hardware-gated and added over time.

  • h100-aks-inference
  • h100-aks-ubuntu-inference

How to refresh evidence

Run on a cluster matching the recipe's criteria:

aicr snapshot -o snapshot.yaml
# Profiled families (AKS gpuStack): capture the pool projection and
# hydrate the recipe with the pointer's recorded 'profile:' selection
# first — validating the raw overlay resolves only the declaration
# default, and 'aicr validate' has no --profile flag:
#   az aks nodepool list -g <rg> --cluster-name <cluster> -o json > pools.json
#   aicr snapshot --aks-gpu-pools pools.json -o snapshot.yaml
#   aicr recipe -s snapshot.yaml --intent <intent> [--platform <platform>] \
#     --profile <name>=<value> -o recipe.yaml
# State the target leaf's intent/platform explicitly (the snapshot
# fingerprint supplies service/accelerator/OS but intent and platform
# default to 'any') and pass -r recipe.yaml below instead of the raw
# overlay.
aicr validate \
  -r recipes/overlays/<slug>.yaml \
  -s snapshot.yaml \
  --emit-attestation ./out \
  --push ghcr.io/<your-fork>/aicr-evidence
# Copy to the per-source path printed in the emit 'copyTo' hint:
#   recipes/evidence/<slug>/<source>/<bundle-digest>.yaml

This gate is warning-only and never blocks merge. See ADR-007 for the trust model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align AKS inference K8s floors with DRA-GA >= 1.34 rationale

2 participants