build(deps): add s3 and gcs extras and floor fsspec (#1256) - #2372
Open
chethanuk wants to merge 1 commit into
Open
build(deps): add s3 and gcs extras and floor fsspec (#1256)#2372chethanuk wants to merge 1 commit into
chethanuk wants to merge 1 commit into
Conversation
`[project.dependencies]` declared a bare `fsspec`, so the >=2025.3.0 floor existed only in `[tool.uv] override-dependencies`, which pip never reads. A pip user installing s3fs/gcsfs alongside Curator could drag fsspec down to that backend's CalVer pin with nothing objecting, and under uv the lock shipped s3fs 2024.12.0 (fsspec==2024.12.0) beside fsspec 2026.3.0 — a pairing s3fs declares invalid. - floor fsspec at >=2025.3.0 in [project.dependencies] - add `s3` (s3fs) and `gcs` (gcsfs) optional-dependencies, rolled into `all` - bump the interleaved_cpu and test-group s3fs entries to >=2025.3.0, which pinned the lock to the broken s3fs - document both extras in the Package Extras table - regenerate uv.lock: 627 -> 630 packages Closes NVIDIA-NeMo#1256 Signed-off-by: ChethanUK <chethanuk@outlook.com>
Contributor
Greptile SummaryThis PR adds supported cloud-storage installation extras and aligns their fsspec dependency floor.
Confidence Score: 5/5The PR appears safe to merge; no concrete correctness, compatibility, security, or documentation defect was established. The extras are represented consistently in project metadata, lock metadata, and documentation, and the changed dependencies support the declared Python range. Existing broader fsspec override conflicts are not introduced by this PR. Important Files Changed
Reviews (1): Last reviewed commit: "build(deps): add s3 and gcs extras and f..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Curator has no cloud-storage extras, so users who want
s3://orgs://paths install s3fs orgcsfs themselves — and nothing stops the version they get from being one Curator cannot use.
Fixes #1256.
Root cause
[project.dependencies]declares a bare, unbounded"fsspec". The>=2025.3.0floor everyonetreats as Curator's pinned range lives only in
[tool.uv] override-dependencies, which pip neverreads and which uv applies by replacing every declared fsspec requirement. Two consequences:
fsspec==<CalVer>pin with nothing objecting;uv.lockalready shipss3fs 2024.12.0(which requiresfsspec==2024.12.0) besidefsspec 2026.3.0— a pairing s3fs itself declares invalid.The missing extras are the symptom. Without the floor, new extras would advertise a range whose
lowest member is broken.
Change
pyproject.toml— floorfsspec>=2025.3.0in[project.dependencies]; adds3(s3fs) andgcs(gcsfs) optional-dependencies, both>=2025.3.0; roll both intoall; bump theinterleaved_cpuandtest-groups3fsentries from>=2024.12.0to>=2025.3.0— thatinterleaved_cpuentry is what pins the lock to the broken s3fs today.uv.lock— regenerated.fern/.../get-started/installation.mdx— two rows in the Package Extras table. Users are toldto pass
s3:///gs://paths with no hint a backend is needed.2025.3.0rather than2024.12.0:s3fs 2024.12.0requiresfsspec==2024.12.0, whichcontradicts the floor. Extra names match
NVIDIA-NeMo/Nemotron; nogsalias, same as there.The
[tool.uv]override at line 354 is left alone — it exists fornemo-toolkit[asr]==2.7.2vsdata-designer-engine==0.5.5.Evidence
Ran with
uv 0.12.1(required-version = ">=0.12.0").Before, on clean
main:Same for
--extra gcs.uv lock --checkpasses on cleanmain, so the lock churn here comesfrom this diff alone.
Lock regenerated in two steps, because plain
uv locktakes the new s3fs/gcsfs but leaves fsspecat 2026.3.0:
After:
627 → 630 packages: adds
gcsfs 2026.8.0,google-auth-oauthlib,google-cloud-storage-control;bumps
s3fs,fsspec, andgoogle-auth 2.45.0 → 2.57.1.uv.lockis +83/−15, not the ~900lines estimated on the issue.
Limitations
fsspec (
nemo_curator/utils/file_utils.py:54-58) — and no test exercises ans3://path, sothere is nothing a Python test could assert. The failing check above is the resolver.
s3fs 2024.12.0 → 2026.7.0changes interleaved-stage behaviour is unverified;confirming it needs S3 credentials.
fsspec override, which masks
nemo-toolkit 2.7.2(fsspec==2024.12.0) anddatasets 4.0.0(
fsspec[http]<=2025.3.0,uv.lock:2063).mainalready exceeded that cap at fsspec 2026.3.0;this widens it to 2026.7.0. Version-scoping that override is a separate change.
s3fsentry in thetestdependency-group is dead — no test references s3fs, moto, or ans3://URL. Bumped for consistency rather than deleted; happy to drop it if maintainers prefer.s3/gcsare not added toCPU_EXTRASininstall-test.yml;--extra allalready coversthem through the rollup.
Upstream issue: #1256