perf(ray-actor-pool): balance weighted RAFT tasks - #2370
Draft
praateekmahajan wants to merge 3 commits into
Draft
Conversation
Signed-off-by: Praateek <praateekm@gmail.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Signed-off-by: Praateek <praateekm@gmail.com>
Contributor
Author
|
/claude review |
Contributor
Author
|
/ok to test d6460ce |
Contributor
Greptile SummaryThe PR adds optional task-weight metadata and uses deterministic largest-first assignment to balance coordinated RAFT work while retaining equal-count splitting when weights are unavailable.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Partitioned input tasks] --> B{All tasks have weights?}
B -- Yes --> C[Sort tasks largest-first]
C --> D[Assign each task to least-loaded RAFT batch]
D --> E[Submit balanced batches to RAFT actors]
B -- No --> F[Split tasks equally by count]
F --> E
Reviews (2): Last reviewed commit: "fix(ray-actor-pool): distribute zero-wei..." | Re-trigger Greptile |
Signed-off-by: Praateek <praateekm@gmail.com>
Contributor
Author
|
/claude review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exact deduplication and fuzzy LSH remain unchanged because they use the shuffle path rather than RAFT batching.
Motivation
Equal task counts can produce uneven per-GPU input sizes, leaving collective KMeans or connected-components workers waiting on the most heavily loaded actor.
Alternatives considered
Testing
EOS benchmark
Run viewer and Comparision
All three relevant 8xH100 entries passed. Compared with the same-day main nightly:
There is no material speedup or slowdown. The full semdedup run reduced per-actor input-row standard deviation from 51,585 to 25, but the baseline imbalance was already only about 0.1% of the mean, so elapsed time remained unchanged.
This is directionally the intended behavior for skewed inputs while remaining neutral on already-balanced data.