Skip to content

fix(audio): support configurable ffmpeg executable - #2350

Draft
mohammadaaftabv wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
mohammadaaftabv:aaftabv/nmcur-397-ffmpeg-config
Draft

fix(audio): support configurable ffmpeg executable#2350
mohammadaaftabv wants to merge 1 commit into
NVIDIA-NeMo:mainfrom
mohammadaaftabv:aaftabv/nmcur-397-ffmpeg-config

Conversation

@mohammadaaftabv

@mohammadaaftabv mohammadaaftabv commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add ffmpeg_executable support for PATH-resolved commands and explicit executable paths.
  • Resolve FFmpeg lazily in each executor worker while preserving runtime environments, Ray task scheduling, and positional constructor compatibility.
  • Return actionable non-root installation guidance when FFmpeg is unavailable.

Validation

Focused resampling and tutorial/Hydra construction tests pass. Ruff, pre-commit, and DCO checks pass.

@copy-pr-bot

copy-pr-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Signed-off-by: aaftaabv@gmail.com <aaftaabv@gmail.com>
@mohammadaaftabv
mohammadaaftabv force-pushed the aaftabv/nmcur-397-ffmpeg-config branch from 29bd1e9 to e06f884 Compare August 28, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant