feat(audio-datasets): make dataset manifest stages agent-ready - #2341
Open
shubhamNvidia wants to merge 1 commit into
Open
feat(audio-datasets): make dataset manifest stages agent-ready#2341shubhamNvidia wants to merge 1 commit into
shubhamNvidia wants to merge 1 commit into
Conversation
Adds describe() contracts to the FLEURS and ReadSpeech initial-manifest stages so a planner can tell what each produces before running it. Depends on the agent-ready foundation (nemo_curator/stages/audio/_agent/), which must merge first. Signed-off-by: Shubham Bhawsar <shbhawsar@nvidia.com>
shubhamNvidia
marked this pull request as ready for review
August 25, 2026 11:19
shubhamNvidia
requested review from
weijiac0619
and removed request for
a team
August 25, 2026 11:19
Contributor
Greptile SummaryAdds agent-facing contracts to the FLEURS and ReadSpeech initial-manifest source stages without changing their dataset-processing paths.
Confidence Score: 5/5The contract changes appear safe to merge once the explicitly required agent-ready foundation dependency is present. The new declarations align with the stages’ emitted keys and existing download and disk-staging behavior, and no unacknowledged actionable defect remains. Important Files Changed
Reviews (1): Last reviewed commit: "feat(audio-datasets): make dataset manif..." | Re-trigger Greptile |
shubhamNvidia
requested review from
ayushdg,
mohammadaaftabv and
sarahyurick
and removed request for
weijiac0619
August 25, 2026 12:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contracts only — no behavior change. Adds
describe()+*_keyparams to the FLEURS and ReadSpeech initial-manifest source stages.These are sources (they produce audio paths + text from nothing), and their contracts declare the two facts a planner has to know up front: they write to disk and they need internet on the first run (when
auto_downloadis on) — so an offline or read-only environment is caught before the run starts rather than partway through a download.Depends on the agent-ready foundation, #2332 — that must merge first (this branch imports
nemo_curator/stages/audio/_agent/, so CI here stays red until it lands).