-
Notifications
You must be signed in to change notification settings - Fork 322
feat(audio-tagging): output control + in-memory handoff + agent-ready contracts #2339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shubhamNvidia
wants to merge
1
commit into
NVIDIA-NeMo:main
Choose a base branch
from
shubhamNvidia:agent/tagging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P0: The full-audio ASR contract writes at the wrong metadata scope
nemo_curator/stages/audio/tagging/inference/nemo_asr_align.py:293-299
declares top-level text/alignment and segments[] text/words writes in full
mode. The normal split path actually writes text and alignment inside
split_metadata[] at lines 439-445.
In the focused reproduction,
validate_pipeline([aligner, MergeAlignmentDiarizationStage(...)]) returned
ok=True, keys_ok=True, the aligner produced only nested values, and the merge
stage then failed backend validation because top-level alignment was absent.
This is a planner-approved pipeline that crashes on a valid input.
Describe full mode as a nested-list transform with
iteration_key=split_metadata_key and nested text/alignment writes; keep
the separate segment-only contract tied to segments_key, and represent the
top-level fallback branch conditionally. Add assert_agent_ready fixtures for
split metadata, the no-splits branch, and segment-only mode, followed by a
planner-plus-runtime chain regression.