feat(audio-metrics): in-memory input + agent-ready contracts - #2336
Open
shubhamNvidia wants to merge 1 commit into
Open
feat(audio-metrics): in-memory input + agent-ready contracts#2336shubhamNvidia wants to merge 1 commit into
shubhamNvidia wants to merge 1 commit into
Conversation
Adds describe() contracts to the bandwidth, SQUIM and WER metric stages so a planner can tell what each reads and writes before running it. Depends on the agent-ready foundation (nemo_curator/stages/audio/_agent/), which must merge first. Signed-off-by: Shubham Bhawsar <shbhawsar@nvidia.com>
shubhamNvidia
marked this pull request as ready for review
August 25, 2026 11:19
shubhamNvidia
requested review from
praateekmahajan
and removed request for
a team
August 25, 2026 11:19
Contributor
Greptile SummaryAdds agent-readable contracts and configurable output keys to the bandwidth, SQUIM, and WER metric stages.
Confidence Score: 5/5The PR appears safe to merge after its explicitly declared agent-foundation dependency lands. No independently actionable defect remains beyond the import failure already documented as an expected dependency-order constraint. Important Files Changed
Reviews (1): Last reviewed commit: "feat(audio-metrics): make metric stages ..." | Re-trigger Greptile |
shubhamNvidia
requested review from
ayushdg,
mohammadaaftabv and
sarahyurick
and removed request for
praateekmahajan
August 25, 2026 12:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contracts:
describe()+*_keyparams on the bandwidth, SQUIM and WER metric stages, includingconditional_writes(a metric is only written when the audio resolves and estimation succeeds).New functionality
input_residency) — read the waveform already in the task rather than re-opening the file for every metric stage. On a chain of several metric stages this removes one file read per stage per row.Per-segment scoring and
metric_skip_reasonalready existed upstream; the contracts here just declare them, so the planner knows a metric is written only when the audio resolves and estimation succeeds.Depends on the agent-ready foundation, #2332 — that must merge first (this branch imports
nemo_curator/stages/audio/_agent/, so CI here stays red until it lands).