feat(audio-filtering): annotate-or-filter mode + agent-ready quality stages - #2335
Open
shubhamNvidia wants to merge 1 commit into
Open
feat(audio-filtering): annotate-or-filter mode + agent-ready quality stages#2335shubhamNvidia wants to merge 1 commit into
shubhamNvidia wants to merge 1 commit into
Conversation
Adds describe() contracts to the band, SIGMOS and UTMOS filter stages so a planner can tell what each reads and writes, and whether it may drop rows, before running it. Depends on the agent-ready foundation (nemo_curator/stages/audio/_agent/), which must merge first. Signed-off-by: Shubham Bhawsar <shbhawsar@nvidia.com>
Contributor
Greptile SummaryThe PR makes the Band, SIGMOS, and UTMOS quality stages agent-ready and adds configurable annotation/filtering, task/segment scope, input residency, and output keys.
Confidence Score: 5/5The PR appears safe to merge after its explicitly declared prerequisite, #2332, is available. No independently actionable defect caused by this change remains after accounting for the acknowledged prerequisite and pre-existing behavior. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[AudioTask] --> B{Scope}
B -->|task| C[Resolve task audio]
B -->|segments| D[Resolve each segment]
C --> E[Band, SIGMOS, or UTMOS inference]
D --> E
E --> F[Write configured score keys]
F --> G{Action}
G -->|annotate| H[Retain every input item]
G -->|filter| I[Retain threshold matches]
Reviews (1): Last reviewed commit: "feat(audio-filtering): make quality filt..." | Re-trigger Greptile |
shubhamNvidia
requested review from
ayushdg,
mohammadaaftabv and
sarahyurick
and removed request for
VibhuJawa
August 25, 2026 12:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contracts:
describe()+*_keyparams on the band, SIGMOS and UTMOS filters, with honestcardinality="filter"so the planner knows these can drop rows.New functionality
action="annotate"vs"filter"— the same stage can now either score every row and keep them all, or score and drop the ones that fail. Previously only dropping was possible, so "show me the quality distribution before I pick a threshold" wasn't expressible.mode="task" | "segments" | "auto") — score a whole file or each segment of a diarized/VAD'd file.input_residency) — score a waveform handed over from the previous stage instead of re-reading the file.Depends on the agent-ready foundation, #2332 — that must merge first (this branch imports
nemo_curator/stages/audio/_agent/, so CI here stays red until it lands).