Skip to content

Docs#43

Merged
NN0X merged 4 commits into
masterfrom
docs
Jun 13, 2025
Merged

Docs#43
NN0X merged 4 commits into
masterfrom
docs

Conversation

@NN0X

@NN0X NN0X commented Jun 13, 2025

Copy link
Copy Markdown
Owner

No description provided.

@NN0X NN0X requested review from Copilot and grzechuzz June 13, 2025 00:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR primarily introduces extensive logging across the backend services and controllers while also including minor code refactorings and dependency injection updates. Key changes include adding ILogger injections and corresponding log messages, improved error-handling and log consistency, and updating project package references.

Reviewed Changes

Copilot reviewed 33 out of 33 changed files in this pull request and generated no comments.

Show a summary per file
File Description
CarWorkshopManager/Services/Implementations/ServiceTaskService.cs Added ILogger injection and logging for service task operations.
CarWorkshopManager/Services/Implementations/ServiceOrderService.cs Integrated logging into order creation, details retrieval, and status change methods.
CarWorkshopManager/Services/Implementations/SendGridEmailWithAttachmentSender.cs Added logging for email sending and error handling.
CarWorkshopManager/Services/Implementations/PartService.cs Introduced logging for part operations (create, update, retrieval, deletion).
CarWorkshopManager/Services/Implementations/OrderCommentService.cs Enhanced logging in the comment addition workflow.
CarWorkshopManager/Services/Implementations/OpenOrdersReportBackgroundService.cs Added logging for background report generation and refactored dependency parameters.
CarWorkshopManager/Services/Implementations/EmailSender.cs Introduced logging for email send operations.
CarWorkshopManager/Services/Implementations/CustomerService.cs, AdminService.cs Added logging in methods handling customer and administrative operations.
Controllers (Vehicle, ServiceOrder, Part, Home, Dashboard, Customer, Admin, Account) Integrated logging in various endpoints to track user interactions and errors.
CarWorkshopManager/CarWorkshopManager.csproj Updated package references with new NLog packages.
CarWorkshopManager/Filters/ExceptionLoggingFilter.cs Created a new filter for logging unhandled exceptions.
Comments suppressed due to low confidence (2)

CarWorkshopManager/Services/Implementations/OpenOrdersReportBackgroundService.cs:55

  • Consider renaming the parameter 'ct' to 'cancellationToken' for improved clarity and consistency with the rest of the codebase.
private async Task GenerateAndSendReport(CancellationToken ct)

CarWorkshopManager/Controllers/AdminController.cs:61

  • The email HTML message appears truncated with an ellipsis; ensure the complete and intended message content is provided before deployment.
await _emailSender.SendEmailAsync(user.Email, "CarworkshopManager - ustaw swoje hasło!", $"<p>Cześć {user.FirstName},</p>...");

grzechuzz
grzechuzz previously approved these changes Jun 13, 2025
@NN0X NN0X merged commit add80d7 into master Jun 13, 2025
1 check failed
@NN0X NN0X deleted the docs branch June 13, 2025 00:29
NN0X added a commit that referenced this pull request Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants