Skip to content

Fix/serviceorder#39

Merged
NN0X merged 10 commits into
masterfrom
fix/serviceorder
Jun 12, 2025
Merged

Fix/serviceorder#39
NN0X merged 10 commits into
masterfrom
fix/serviceorder

Conversation

@grzechuzz

Copy link
Copy Markdown
Collaborator

No description provided.

@NN0X NN0X linked an issue Jun 12, 2025 that may be closed by this pull request
@NN0X NN0X requested a review from Copilot June 12, 2025 22:31

This comment was marked as outdated.

NN0X and others added 2 commits June 13, 2025 00:38
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@NN0X NN0X requested review from NN0X and Copilot June 12, 2025 22:39

This comment was marked as outdated.

@NN0X NN0X requested a review from Copilot June 12, 2025 22:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses fixes and enhancements for the service order functionality. Key changes include updating UI elements in the service order details view, adding new endpoints and view model properties for handling tasks and parts, and refactoring status and order totals logic.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
CarWorkshopManager/Views/ServiceOrder/Details.cshtml Updated display of order details, tasks, and comments with improved formatting.
CarWorkshopManager/ViewModels/ServiceTasks/ServiceTaskListItemViewModel.cs Added properties for labor and parts costs.
CarWorkshopManager/ViewModels/ServiceOrder/ServiceOrderDetailsViewModel.cs Added the Description property.
CarWorkshopManager/Services/Interfaces/IServiceOrderService.cs Introduced a new method for retrieving order totals.
CarWorkshopManager/Services/Implementations/ServiceOrderService.cs Refactored status selection and implemented the order totals method.
CarWorkshopManager/Services/Implementations/OpenOrdersReportBackgroundService.cs Removed unused using statements.
CarWorkshopManager/Controllers/ServiceTasksController.cs Deleted redundant controller.
CarWorkshopManager/Controllers/ServiceOrderController.cs Added endpoints for task and part additions, and integrated order totals.
CarWorkshopManager/CarWorkshopManager.csproj Removed an unnecessary folder include.
Comments suppressed due to low confidence (1)

CarWorkshopManager/Views/ServiceOrder/Details.cshtml:231

  • [nitpick] Consider using a more descriptive variable name instead of 'c' (e.g. 'comment') in the comments loop for improved code readability.
@foreach (var c in Model.Comments)

Comment thread CarWorkshopManager/Controllers/ServiceOrderController.cs
@NN0X NN0X merged commit 4dcea72 into master Jun 12, 2025
1 check passed
@NN0X NN0X deleted the fix/serviceorder branch June 12, 2025 22:48
NN0X added a commit that referenced this pull request Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ServiceOrder/Design

3 participants