Repository navigation
Bump Mutagen to 0.54.4: Starfield NPCs lose all but the first tint layer - #146
Open
taosecurity wants to merge 1 commit into
Open
taosecurity wants to merge 1 commit into
taosecurity wants to merge 1 commit into
Conversation
Mutagen 0.54.0 and 0.54.1 read only the first tint layer of a Starfield NPC_ record (the repeated MNAM/TNAM/QNAM/VNAM/NNAM/INTV blocks counted by EDCT). Spriggit 0.41.0 bundles 0.54.0, so serializing an NPC drops every makeup/skin layer after the first, and deserializing writes only one back. Mutagen 0.54.2 and later read all layers. Repro: a plugin holding a copy of vanilla Companion_SarahMorgan (9 tint layers) serializes to 1 TintType entry with 0.41.0 and to 9 with this change, and rebuilds with all 9. Spriggit.Tests: 129 passed, 1 skipped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Spriggit 0.41.0 (Mutagen 0.54.0) drops every tint layer of a Starfield
NPC_record except the first. These are the repeatedMNAM/TNAM/QNAM/VNAM/NNAM/INTVblocks (makeup and skin layers, counted byEDCT). The serialized YAML holds a singleTintsentry, and deserializing writesEDCT = 1with one layer, so an NPC loses its blush, lipstick, eyeshadow, eyeliner, etc. on any round trip.The cause is Mutagen itself, not Spriggit's serialization. Reading the same plugin directly:
Companion_SarahMorgan(9 in the ESM)Change
Raise the nine
[0.54.0]Mutagen pins inDirectory.Packages.propsto[0.54.4]. The Mutagen.Bethesda.Serialization packages stay at 1.38.6.Testing
Spriggit.Tests: 129 passed, 0 failed, 1 skipped.Companion_SarahMorgan.TintTypeentry and the rebuilt plugin 1 layer.EDCT = 09with 9 layers.The same bump on the
0.41.0tag is what I'm using locally until a release ships.Thank you for this awesome software! You have made it possible for me to create several new projects.
Sincerely,
Richard
🤖 Generated with Claude Code