memories, fully-clean.cases: cross-link the two superseded-head records - #2916
Conversation
Closes #2912. #2907 added a bullet to memories/github-mcp-tools.md on check_suite.completed events that name a superseded head, written as if the corpus had no prior record. fully-clean.cases.md already carried one (ucdavis/bcs#732, 2026-08-23). Neither referenced the other. The gap was asserted from a grep of memories/ and a targeted read, which is the grep-is-not-coverage failure. Add one pointer in each direction and delete nothing: the two records measure different sessions and repositories, and the memory bullet's new content (the corrected "no CI success events" claim, the App-suite exclusions, the cross-repo occurrences) is not in the case. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017trXKZFoCYC4kP7NKNnN6F
|
Claude finished review — View run No prior comments on this PR. This is a small, self-contained documentation change adding a bidirectional cross-reference between two existing case records about I verified both quoted section titles ("A This is exactly the kind of change the repo's own No factual, structural, or style problems found:
VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.0",
"reviewer": "claude",
"commit_sha": "121d99a",
"verdict": "CLEAN",
"findings": []
}Reviewed commit: 82c82b0 |
Closes #2912.
What
#2907 added a bullet to
memories/github-mcp-tools.mdoncheck_suite.completedevents that name a superseded head, written as if the corpus had no prior record.shared/workflow/fully-clean.cases.mdalready carried one —## A check_suite.completed wake at a superseded head(ucdavis/bcs#732, 2026-08-23). Neither referenced the other.This adds one pointer in each direction, as real relative links so
check-links.pyvalidates them, and deletes nothing.Why not consolidate
The two records measure different sessions and repositories, and the memory bullet's substantive content — the corrected "webhooks do not deliver CI success" claim, the App-suite and cancelled-suite exclusions the event declares, the lower-bound framing, and the cross-repo occurrences — is not in the case.
challenge-redundant-contentsays merge only when nothing is lost; here something would be.How the gap happened
The absence was asserted from a grep of
memories/plus a targeted read of one bullet — a phrase search over a subset returned nothing and was read as "the corpus lacks this". That is thegrep-is-not-coveragefailure verbatim, and it was mine, on #2907.Verification
new-line-breaksrun after committing, with a negative control (appended two-sentence line → exit 1; reverted → exit 0). No non-ASCII in added lines.check-links.py: no broken relative links, which covers both new cross-file links.Disjoint from open #2913 (
preferences.md,ardia,gia) — no merge-order constraint.🤖 Generated with Claude Code
https://claude.ai/code/session_017trXKZFoCYC4kP7NKNnN6F
Generated by Claude Code