Item Interactions

[CheffieGithub]

About The Pull Request

ABOUT

This pr is going to replace attackby item interactions with real ones based on MrMelbert's work tgstation/tgstation#79968 tgstation/tgstation#83818

Item interactions will take place after tool interactions (which we have none of) and before regular attacks.

SURGERY

I changed a bit about surgeries because they were so awful I had to. (and because their start was moved to an interaction)

Surgeries are started via the same way but now require you to not be in combat mode and be on weak intent.

Surgeries refactored to use surgeries and updated to latest TG code that uses limb states, this is practically a better version of what it is currently, except with a radial instead of a pop-up list.

Intentional surgery failure is done by right click instead of strong intent to not conflict killing people

Having not enough skill for surgery just simply forces you to fail, so you can still get experience and be malicious.

Wound cautery changed to a cautery interaction on mobs, the cautery can still be used to close skin.

Opening organ storage requires weak instead of touch

INTERACTION CHANGES

You can force feed food to others.

Syringes inject on left click and draw on right click.

Giving items moved to ctrl+shift click or the rebindable keybind "G". The keybind is reliant on getting a turf from the mouse and doesn't work when in the process of moving so stand still if you want to use it or use the static bind.

Slot machine is empty hand right click not attackby

todo for non attack interactions

• attack
• attackby (obvious ones)
• attack_atom (all)
• afterattack (most)
• preattack (most)

Why It's Good For The Game

Allows atom storage to be better, will cleanup afterattack, preattack, attackby misuse and attack chain precedence.

Changelog

🆑
refactor: Refactored attack chain code, report any issues with clicking on things with other things.
refactor: Refactored surgery code, report any cases of surgery issues.
add: Giving is now done by ctrl+shift click or the hotkey "G"
add: Some interactions have been changed that will not be listed here, check the PR page before reporting things.
/:cl:

Pre-Merge Checklist

• You tested this on a local server.
• This code did not runtime during testing.
• You documented all of your changes.

[Blacklist897]

if you are removing tool embeds, replace the spare forceps in surgical bags with something else

[CheffieGithub]

With air so you can have some space

[Gatsby229]

The amount of things this breaks is insane... Its effecting literally everything, and there does not seem to be much action to FIX the things it breaks. Some of the zizo spells have been bricked because of this.

[CheffieGithub]

Have you like looked at the commits at all? If you want shit fixed then bug report it instead of complaining about it