Skip to content

[refactor]: rope as module #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Watebear wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[refactor]: rope as module #1238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fe8d566
[refactor]: rope as module
Watebear Jul 13, 2026
b19053e
[refactor]: update configs
Watebear Jul 13, 2026
d15158b
[fix]: world play & hunyuanvideo & ernie_image
Watebear Jul 13, 2026
5bbcc65
[fix]: platform configs
Watebear Jul 13, 2026
97dbad4
[fix]: rm unnecessary
Watebear Jul 14, 2026
c696985
config
Watebear Jul 14, 2026
ecba310
Delete assets/inputs/imgs/seedvr.jpg
Watebear Jul 14, 2026
5dac574
[refactor]: align rope with weight module conventions
Watebear Jul 14, 2026
4054807
[refactor]: instantiate rope from registry directly
Watebear Jul 14, 2026
70a724f
[fix]: register chunked rope and normalize ltx2 config
Watebear Jul 16, 2026
be09a15
[test]: sync test cases with main
Watebear Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/gradio_demo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ def run_inference(
"boundary_step_index": 2,
"boundary": 0.900,
"use_image_encoder": False if "wan2.2" in model_cls else True,
"rope_type": "torch",
"rope_type": "torch_complex_rope",
"t5_lazy_load": lazy_load,
"bucket_shape": {
"0.667": [[480, 832], [544, 960], [720, 960]],
Expand Down
2 changes: 1 addition & 1 deletion configs/cosmos3/cosmos3_super_i2v.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"feature_caching": "NoCaching",
"rms_norm_type": "one-pass",
"attn_rms_norm_type": "one-pass",
"rope_type": "triton",
"rope_type": "cosmos3_rope",
"self_attn_type": "flash_attn3",
"causal_self_attn_type": "flash_attn3",
"add_resolution_template": false,
Expand Down
2 changes: 1 addition & 1 deletion configs/cosmos3/cosmos3_super_omni_action_fd_agibotworld.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"feature_caching": "NoCaching",
"rms_norm_type": "one-pass",
"attn_rms_norm_type": "one-pass",
"rope_type": "triton",
"rope_type": "cosmos3_rope",
"self_attn_type": "flash_attn3",
"causal_self_attn_type": "flash_attn3",
"add_resolution_template": false,
Expand Down
2 changes: 1 addition & 1 deletion configs/cosmos3/cosmos3_super_omni_action_fd_agibotworld_multichunk.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"feature_caching": "NoCaching",
"rms_norm_type": "one-pass",
"attn_rms_norm_type": "one-pass",
"rope_type": "triton",
"rope_type": "cosmos3_rope",
"self_attn_type": "flash_attn3",
"causal_self_attn_type": "flash_attn3",
"add_resolution_template": false,
Expand Down
2 changes: 1 addition & 1 deletion configs/cosmos3/cosmos3_super_omni_action_id_av.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"feature_caching": "NoCaching",
"rms_norm_type": "one-pass",
"attn_rms_norm_type": "one-pass",
"rope_type": "triton",
"rope_type": "cosmos3_rope",
"self_attn_type": "flash_attn3",
"causal_self_attn_type": "flash_attn3",
"add_resolution_template": false,
Expand Down
2 changes: 1 addition & 1 deletion configs/cosmos3/cosmos3_super_omni_i2av.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"feature_caching": "NoCaching",
"rms_norm_type": "one-pass",
"attn_rms_norm_type": "one-pass",
"rope_type": "triton",
"rope_type": "cosmos3_rope",
"self_attn_type": "flash_attn3",
"causal_self_attn_type": "flash_attn3",
"add_resolution_template": false,
Expand Down
2 changes: 1 addition & 1 deletion configs/cosmos3/cosmos3_super_omni_i2v.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"feature_caching": "NoCaching",
"rms_norm_type": "one-pass",
"attn_rms_norm_type": "one-pass",
"rope_type": "triton",
"rope_type": "cosmos3_rope",
"self_attn_type": "flash_attn3",
"causal_self_attn_type": "flash_attn3",
"add_resolution_template": false,
Expand Down
2 changes: 1 addition & 1 deletion configs/cosmos3/cosmos3_super_omni_t2av.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"feature_caching": "NoCaching",
"rms_norm_type": "one-pass",
"attn_rms_norm_type": "one-pass",
"rope_type": "triton",
"rope_type": "cosmos3_rope",
"self_attn_type": "flash_attn3",
"causal_self_attn_type": "flash_attn3",
"add_resolution_template": false,
Expand Down
2 changes: 1 addition & 1 deletion configs/cosmos3/cosmos3_super_omni_t2v.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"feature_caching": "NoCaching",
"rms_norm_type": "one-pass",
"attn_rms_norm_type": "one-pass",
"rope_type": "triton",
"rope_type": "cosmos3_rope",
"self_attn_type": "flash_attn3",
"causal_self_attn_type": "flash_attn3",
"add_resolution_template": false,
Expand Down
2 changes: 1 addition & 1 deletion configs/cosmos3/cosmos3_super_t2i.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"feature_caching": "NoCaching",
"rms_norm_type": "one-pass",
"attn_rms_norm_type": "one-pass",
"rope_type": "triton",
"rope_type": "cosmos3_rope",
"self_attn_type": "flash_attn3",
"causal_self_attn_type": "flash_attn3",
"cosmos3_meta_init": true,
Expand Down
2 changes: 1 addition & 1 deletion configs/cosmos3/cosmos3_super_t2v.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"feature_caching": "NoCaching",
"rms_norm_type": "one-pass",
"attn_rms_norm_type": "one-pass",
"rope_type": "triton",
"rope_type": "cosmos3_rope",
"self_attn_type": "flash_attn3",
"causal_self_attn_type": "flash_attn3",
"add_resolution_template": false,
Expand Down
2 changes: 1 addition & 1 deletion configs/flux2/flux2_dev.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@
"enable_cfg": false,
"patch_size": 2,
"tokenizer_max_length": 512,
"rope_type": "flashinfer",
"rope_type": "flashinfer_rope",
"text_encoder_out_layers": [10, 20, 30]
}
2 changes: 1 addition & 1 deletion configs/flux2/flux2_dev_offload.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"enable_cfg": false,
"patch_size": 2,
"tokenizer_max_length": 512,
"rope_type": "flashinfer",
"rope_type": "flashinfer_rope",
"text_encoder_out_layers": [10, 20, 30],
"cpu_offload": true,
"offload_granularity": "model"
Expand Down
2 changes: 1 addition & 1 deletion configs/flux2/flux2_klein.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
"enable_cfg": true,
"patch_size": 2,
"tokenizer_max_length": 512,
"rope_type": "flashinfer"
"rope_type": "flashinfer_rope"
}
2 changes: 1 addition & 1 deletion configs/flux2/flux2_klein_distill.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
"enable_cfg": false,
"patch_size": 2,
"tokenizer_max_length": 512,
"rope_type": "flashinfer"
"rope_type": "flashinfer_rope"
}
2 changes: 1 addition & 1 deletion configs/flux2/flux2_klein_distill_fls.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"enable_cfg": false,
"patch_size": 2,
"tokenizer_max_length": 512,
"rope_type": "flashinfer",
"rope_type": "flashinfer_rope",
"fls": {
"enable": true,
"fovea_strength": 10,
Expand Down
2 changes: 1 addition & 1 deletion configs/flux2/flux2_klein_distill_offload.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"enable_cfg": false,
"patch_size": 2,
"tokenizer_max_length": 512,
"rope_type": "flashinfer",
"rope_type": "flashinfer_rope",
"cpu_offload": true,
"offload_granularity": "model"
}
2 changes: 1 addition & 1 deletion configs/flux2/flux2_klein_i2i_distill.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
"enable_cfg": false,
"patch_size": 2,
"tokenizer_max_length": 512,
"rope_type": "flashinfer"
"rope_type": "flashinfer_rope"
}
2 changes: 1 addition & 1 deletion configs/flux2/flux2_klein_i2i_distill_edit.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@
"enable_cfg": false,
"patch_size": 2,
"tokenizer_max_length": 512,
"rope_type": "flashinfer"
"rope_type": "flashinfer_rope"
}
2 changes: 1 addition & 1 deletion configs/flux2/flux2_klein_i2i_distill_edit_ulysses.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"enable_cfg": false,
"patch_size": 2,
"tokenizer_max_length": 512,
"rope_type": "flashinfer",
"rope_type": "flashinfer_rope",
"parallel": {
"seq_p_size": 2,
"seq_p_attn_type": "ulysses"
Expand Down
2 changes: 1 addition & 1 deletion configs/flux2/flux2_klein_i2i_distill_ulysses.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"enable_cfg": false,
"patch_size": 2,
"tokenizer_max_length": 512,
"rope_type": "flashinfer",
"rope_type": "flashinfer_rope",
"parallel": {
"seq_p_size": 2,
"seq_p_attn_type": "ulysses"
Expand Down
2 changes: 1 addition & 1 deletion configs/flux2/flux2_klein_i2i_edit.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@
"enable_cfg": true,
"patch_size": 2,
"tokenizer_max_length": 512,
"rope_type": "flashinfer"
"rope_type": "flashinfer_rope"
}
2 changes: 1 addition & 1 deletion configs/flux2/flux2_klein_i2i_edit_cfg_parallel.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"enable_cfg": true,
"patch_size": 2,
"tokenizer_max_length": 512,
"rope_type": "flashinfer",
"rope_type": "flashinfer_rope",
"parallel": {
"cfg_p_size": 2
}
Expand Down
2 changes: 1 addition & 1 deletion configs/flux2/flux2_klein_i2i_edit_cfg_parallel_8step.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"enable_cfg": true,
"patch_size": 2,
"tokenizer_max_length": 512,
"rope_type": "flashinfer",
"rope_type": "flashinfer_rope",
"parallel": {
"cfg_p_size": 2
}
Expand Down
2 changes: 1 addition & 1 deletion configs/flux2/flux2_klein_i2i_inpaint_mask.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"enable_cfg": true,
"patch_size": 2,
"tokenizer_max_length": 512,
"rope_type": "flashinfer",
"rope_type": "flashinfer_rope",
"max_image_area": 1048576,
"inpaint_mask_enabled": true
}
2 changes: 1 addition & 1 deletion configs/flux2/flux2_klein_i2i_inpaint_mask_cache.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"enable_cfg": true,
"patch_size": 2,
"tokenizer_max_length": 512,
"rope_type": "flashinfer",
"rope_type": "flashinfer_rope",
"max_image_area": 1048576,
"inpaint_mask_enabled": true
}
2 changes: 1 addition & 1 deletion configs/flux2/flux2_klein_i2i_inpaint_mask_cfg_parallel.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"enable_cfg": true,
"patch_size": 2,
"tokenizer_max_length": 512,
"rope_type": "flashinfer",
"rope_type": "flashinfer_rope",
"max_image_area": 1048576,
"inpaint_mask_enabled": true,
"parallel": {
Expand Down
2 changes: 1 addition & 1 deletion configs/flux2/flux2_klein_i2i_inpaint_mask_cfg_parallel_cache.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"enable_cfg": true,
"patch_size": 2,
"tokenizer_max_length": 512,
"rope_type": "flashinfer",
"rope_type": "flashinfer_rope",
"max_image_area": 1048576,
"inpaint_mask_enabled": true,
"parallel": {
Expand Down
2 changes: 1 addition & 1 deletion configs/hidream_o1_image/hidream_o1_image_i2i.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"shift": 3.0,
"scheduler_name": "default",
"attn_type": "flash_attn3",
"rope_type": "flashinfer",
"rope_type": "flashinfer_rope",
"target_height": 2048,
"target_width": 2048,
"keep_original_aspect": true,
Expand Down
2 changes: 1 addition & 1 deletion configs/hidream_o1_image/hidream_o1_image_i2i_layout.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"shift": 1.0,
"scheduler_name": "default",
"attn_type": "flash_attn3",
"rope_type": "flashinfer",
"rope_type": "flashinfer_rope",
"target_height": 2048,
"target_width": 2048,
"keep_original_aspect": false,
Expand Down
2 changes: 1 addition & 1 deletion configs/hidream_o1_image/hidream_o1_image_i2i_multi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"shift": 1.0,
"scheduler_name": "default",
"attn_type": "flash_attn3",
"rope_type": "flashinfer",
"rope_type": "flashinfer_rope",
"target_height": 2048,
"target_width": 2048,
"keep_original_aspect": false,
Expand Down
2 changes: 1 addition & 1 deletion configs/hidream_o1_image/hidream_o1_image_t2i.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"shift": 3.0,
"scheduler_name": "default",
"attn_type": "flash_attn3",
"rope_type": "flashinfer",
"rope_type": "flashinfer_rope",
"target_height": 2048,
"target_width": 2048,
"keep_original_aspect": false,
Expand Down
2 changes: 1 addition & 1 deletion configs/hidream_o1_image/hidream_o1_image_t2i_dev_2604.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@
"enable_cfg": false,
"rms_norm_type": "one-pass",
"attn_type": "flash_attn3",
"rope_type": "flashinfer"
"rope_type": "flashinfer_rope"
}
2 changes: 1 addition & 1 deletion configs/hidream_o1_image/hidream_o1_image_t2i_dev_2604_dist.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"enable_cfg": false,
"rms_norm_type": "one-pass",
"attn_type": "flash_attn3",
"rope_type": "flashinfer",
"rope_type": "flashinfer_rope",
"parallel": {
"seq_p_size": 2,
"seq_p_attn_type": "ulysses"
Expand Down
2 changes: 1 addition & 1 deletion configs/hidream_o1_image/mlu/hidream_o1_image_i2i_dist.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"shift": 3.0,
"scheduler_name": "default",
"attn_type": "mlu_flash_attn",
"rope_type": "torch",
"rope_type": "torch_real_rope",
"target_height": 2048,
"target_width": 2048,
"keep_original_aspect": true,
Expand Down
2 changes: 1 addition & 1 deletion configs/hidream_o1_image/mlu/hidream_o1_image_t2i_dev_2604.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"enable_cfg": false,
"cpu_offload": false,
"attn_type": "mlu_flash_attn",
"rope_type": "torch",
"rope_type": "torch_real_rope",
"ln_type": "torch",
"layer_norm_type": "torch",
"rms_norm_type": "mlu_rms_norm"
Expand Down
2 changes: 1 addition & 1 deletion configs/hidream_o1_image/mlu/hidream_o1_image_t2i_dev_2604_dist.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"enable_cfg": false,
"cpu_offload": false,
"attn_type": "mlu_flash_attn",
"rope_type": "torch",
"rope_type": "torch_real_rope",
"ln_type": "torch",
"layer_norm_type": "torch",
"rms_norm_type": "mlu_rms_norm",
Expand Down
2 changes: 1 addition & 1 deletion configs/lingbot_fast/lingbot_fast_i2v.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@
"sink_size": 3,
"kv_offload": false
},
"causal_rope_type": "triton"
"causal_rope_type": "wan_causal_rope"
}
2 changes: 1 addition & 1 deletion configs/lingbot_fast/lingbot_fast_i2v_kv_kiviquant.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,5 @@
},
"kv_offload": false
},
"causal_rope_type": "triton"
"causal_rope_type": "wan_causal_rope"
}
3 changes: 2 additions & 1 deletion configs/ltx2/ltx2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
"audio_fps": 24000,
"audio_mel_bins":16,
"double_precision_rope": true,
"rope_type": "torch_real_rope",
"use_tiling_vae": false,
"dit_original_ckpt": "Lightricks/LTX-2/ltx-2-19b-dev.safetensors"
"dit_original_ckpt": "/LTX-2/ltx-2-19b-dev.safetensors"
}
2 changes: 1 addition & 1 deletion configs/ltx2/ltx2_3.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"audio_mel_bins":16,
"double_precision_rope": true,
"use_tiling_vae": false,
"dit_original_ckpt": "Lightricks/LTX-2.3/ltx-2.3-22b-dev.safetensors",
"dit_original_ckpt": "/LTX-2.3/ltx-2.3-22b-dev.safetensors",
"caption_proj_before_connector": true,
"cross_attention_adaln": true,
"apply_gated_attention": true,
Expand Down
2 changes: 1 addition & 1 deletion configs/matrix_game2/matrix_game2_gta_drive.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,5 @@
"num_layers": 30,
"out_dim": 16,
"use_image_encoder": false,
"causal_rope_type": "triton"
"causal_rope_type": "wan_causal_rope"
}
2 changes: 1 addition & 1 deletion configs/matrix_game2/matrix_game2_gta_drive_streaming.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,5 @@
"num_layers": 30,
"out_dim": 16,
"use_image_encoder": false,
"causal_rope_type": "triton"
"causal_rope_type": "wan_causal_rope"
}
2 changes: 1 addition & 1 deletion configs/matrix_game2/matrix_game2_templerun.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,5 +59,5 @@
"num_layers": 30,
"out_dim": 16,
"use_image_encoder": false,
"causal_rope_type": "triton"
"causal_rope_type": "wan_causal_rope"
}
2 changes: 1 addition & 1 deletion configs/matrix_game2/matrix_game2_templerun_streaming.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,5 @@
"num_layers": 30,
"out_dim": 16,
"use_image_encoder": false,
"causal_rope_type": "triton"
"causal_rope_type": "wan_causal_rope"
}
2 changes: 1 addition & 1 deletion configs/matrix_game2/matrix_game2_universal.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,5 +67,5 @@
"num_layers": 30,
"out_dim": 16,
"use_image_encoder": false,
"causal_rope_type": "triton"
"causal_rope_type": "wan_causal_rope"
}
2 changes: 1 addition & 1 deletion configs/matrix_game2/matrix_game2_universal_streaming.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,5 +66,5 @@
"num_layers": 30,
"out_dim": 16,
"use_image_encoder": false,
"causal_rope_type": "triton"
"causal_rope_type": "wan_causal_rope"
}
Loading
Loading