[Bugfix] Adjust log rate limiting defaults - #1239
Open
dante159753 wants to merge 1 commit into
Open
Conversation
dante159753
marked this pull request as ready for review
August 18, 2026 06:30
dante159753
requested review from
FangRun2,
Tarrei,
Wwwzff,
mag1c-h and
ygwpz
as code owners
August 18, 2026 06:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
A longer default window reduces repeated log noise. Health breaker transitions are operationally significant state changes, so they must remain visible even when multiple transitions occur within one rate-limit window.
Impact
Rate-limited logs now allow at most three entries per call site in a 60-second window by default.
UCM_LOG_RATE_LIMIT_WINDOW_MScan still override the default. Store health breaker transition warnings are always emitted.Verification
codespell,black, andisortpassed.test/test_logger.pypassed.python -m pytest test/test_logger.py -qwas also attempted, but the Windows test environment stopped in the repository-wide fixture because the Unix-onlyfcntlmodule is unavailable.