[Bugfix] Propagate shared cache load failures - #1158
Draft
dante159753 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Prevent shared Cache buffers from being reused while an asynchronous backend still accesses them, and propagate backend load failures to every rank waiting on the same shared entry.
Modifications
LOADING/READY/FAILEDstate and retain the backend failure statusUser impact
When one rank owns a shared Cache load and the backend fails or times out, peer ranks now observe the same failure instead of waiting indefinitely or treating incomplete KV data as ready. Backend IO also cannot outlive and silently overwrite a reused cache buffer.
Verification
git diff --checkorigin/develop: Debug/Ascend build passed;ucmstore.test89/89 passeducmshared.test: 35/37 in the full run; the two logger ordering tests passed 2/2 when rerun together in isolationCache|Posix, AIO, O_DIRECT, layerwise, recompute: after truncating one Posix KV file and injecting delayed reads, only the owning rank issued backend loads, the peer consumed the shared failure, recovery completed, and generated token IDs matched the baseline