-
Notifications
You must be signed in to change notification settings - Fork 727
Bugfix: retain agent during thread switches #3884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4418273
fix(newchat): retain selected agent across thread switches
xuyaqist 5a7f9e5
Merge branch 'develop' into xyq/bugfix_2.5.1-2
xuyaqist d539ef4
fix(newchat): retain agent during thread switches
xuyaqist 66ec43e
fix(newchat): initialize agent thread metadata
xuyaqist c1667df
chore(storage): remove image fetch status log
xuyaqist File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| import assert from "node:assert/strict"; | ||
| import { readFile } from "node:fs/promises"; | ||
| import test from "node:test"; | ||
|
|
||
| const pagePath = new URL("../app/[locale]/newchat/page.tsx", import.meta.url); | ||
| const adapterPath = new URL( | ||
| "../app/[locale]/newchat/adapter/conversation-thread-list-adapter.tsx", | ||
| import.meta.url | ||
| ); | ||
|
|
||
| test("binds an agent selected for a new thread to that thread's metadata", async () => { | ||
| const page = await readFile(pagePath, "utf8"); | ||
|
|
||
| assert.match( | ||
| page, | ||
| /thread\.updateCustom\(\{\s*agentId:\s*agent\.id\s*\}\)/ | ||
| ); | ||
| }); | ||
|
|
||
| test("initializes a new thread before storing its selected agent", async () => { | ||
| const page = await readFile(pagePath, "utf8"); | ||
|
|
||
| assert.match( | ||
| page, | ||
| /const thread = runtime\.threads\.getItemById\([\s\S]*await thread\.initialize\(\);[\s\S]*await thread\.updateCustom\(/ | ||
| ); | ||
| }); | ||
|
|
||
| test("supports storing an agent on a new thread before the conversation exists on the server", async () => { | ||
| const adapter = await readFile(adapterPath, "utf8"); | ||
|
|
||
| assert.match( | ||
| adapter, | ||
| /async updateCustom\(\s*_remoteId: string,\s*_custom: Record<string, unknown> \| undefined\s*\): Promise<void>/ | ||
| ); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.