Conversation
ayiya12
requested review from
Dallas98,
WMC001 and
jeffwu-1999
as code owners
September 4, 2026 07:57
xuyaqist
reviewed
Sep 4, 2026
Comment on lines
+56
to
+60
| {description ? ( | ||
| <div className="mt-4 line-clamp-3 text-sm leading-6 text-slate-600"> | ||
| {description} | ||
| </div> | ||
| ) : null} |
Contributor
There was a problem hiding this comment.
description的下面是不是还加一排 tags的展示？
badge和tag两个概念可以区分
xuyaqist
reviewed
Sep 4, 2026
Comment on lines
+35
to
+40
| <ResourceCardShell | ||
| onClick={onClick} | ||
| selected={selected} | ||
| className={className} | ||
| containerRef={containerRef} | ||
| > |
Contributor
There was a problem hiding this comment.
Shell的作用是什么？没有感觉这个前端组件的必要性，看是不是把它删掉呢。
只保留：
- CreateResourceCard，表示新建的卡片
- ResourceCard，表示一个可选择的卡片。
- ResourceCardGrid，包含上面的toolbar和下面的Card Grid，以及分页功能。如果用户要复用，就会直接使用这个ResourceCardGrid，不需要把toolbar单独拆分出来，因为Grid总是要包含search和分类，这些功能应该打包成一套。
（1）支持传递一个参数，这个参数可控制是否展示CreateResourceCard
（2）支持配置x和y，也就是几行几列。主要为了适配用户自定义个数。 - “我的智能体”搭配一些按钮“智能体仓库、导入智能体”，这个可以单独拆分出一个前端组件
这个功能删掉吧，因为如果这个上面单独拆分成一个组件，感觉和下面重复了，会导致一个函数在多个组件中传递
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The grid empty-state logic conflicts with the provided total API (can show empty while data exists), and the PR description lists extracted components that are not present in the actual change set.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR introduces reusable frontend building blocks for rendering “resource” cards and a grid container, aiming to standardize card layout, creation affordance, and list UI (search/filter/pagination) across resource screens.
Changes:
- Added a generic
ResourceCardcomponent that supports icons, badges, tags, actions, footer/meta, and an optional “clickable card” mode. - Added
ResourceCardGridto render a responsive grid with optional toolbar (search + filters), optional create-card slot, empty state, and pagination. - Added
CreateResourceCardas a dedicated “new resource” dashed card button.
File summaries
| File | Description |
|---|---|
| frontend/components/resource/ResourceCardGrid.tsx | Generic grid container with optional toolbar, create card slot, empty state, and pagination. |
| frontend/components/resource/ResourceCard.tsx | Reusable resource card template supporting interactive and non-interactive variants. |
| frontend/components/resource/CreateResourceCard.tsx | Specialized “create new resource” card button with icon + title. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
说这里还可以加1-2个图标按钮，比如说mcp的连通性校验
|
Contributor
Author
|
增加headeractions |
xuyaqist
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.ResourceCard.tsx：通用资源卡片内容模板
2.CreateResourceCard.tsx：用于“新建资源”的特殊卡片
3.ResourceCardGrid.tsx：卡片网格、搜索、筛选、分页、空状态容器