🐛 Fix term position weighting - #3833
Open
original4422 wants to merge 1 commit into
Open
Conversation
original4422
requested review from
Dallas98,
WMC001 and
jeffwu-1999
as code owners
August 31, 2026 21:50
Author
|
@WMC001 Hi! When you have a moment, could you please check whether this PR is ready to merge or let me know if any changes are needed? Thank you! |
Author
|
@WMC001 Hi, when you have a moment, could you please check whether this PR is ready to merge or needs any changes? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
calculate_term_weightscompared a token index with one third of the raw character length. Character length is unrelated to the retained token stream, so end-of-query terms were not weighted consistently. The loop index also included tokens later discarded as whitespace or stop words.Validation
uv run --no-project --with pytest --with jieba python -m pytest test/sdk/core/nlp/test_tokenizer.py -q(1 passed)uv run --no-project --with ruff ruff check --ignore I001 sdk/nexent/core/nlp/tokenizer.py test/sdk/core/nlp/test_tokenizer.pyuv run --no-project --with ruff ruff format --check test/sdk/core/nlp/test_tokenizer.pygit diff --checkpython3 -m compileall -q sdk/nexent/core/nlp/tokenizer.py test/sdk/core/nlp/test_tokenizer.pyFixes #3811