🐛 Fix signed integer list parsing - #3828
Open
original4422 wants to merge 1 commit into
Open
Conversation
original4422
requested review from
Dallas98,
WMC001 and
jeffwu-1999
as code owners
August 31, 2026 09:28
Author
|
Hi @Dallas98, when you have a chance, could you please take a look and let me know whether this is ready to merge or needs any changes? Thank you. |
Author
|
Hi @WMC001, when you have a chance, could you please review this signed-integer parsing fix and let me know if any changes are needed before it can be merged? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
str.isdigit()Root cause
convert_string_to_listfiltered tokens throughstr.isdigit()before conversion. That rejected-1and+1, even thoughconvert_list_to_stringcan serialize negative integers, and it silently discarded malformed entries.Validation
uvx --from pytest pytest test/backend/utils/test_str_utils.py -q(18 passed)uvx ruff check --select E,F,I backend/utils/str_utils.py test/backend/utils/test_str_utils.pyuvx ruff format --check backend/utils/str_utils.py test/backend/utils/test_str_utils.pypython3 -m compileall -q backend/utils/str_utils.py test/backend/utils/test_str_utils.pygit diff --checkFixes #3818