Skip to content

馃悰 preserve IPv6 brackets in A2A base URLs #3796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ump45nose wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

馃悰 preserve IPv6 brackets in A2A base URLs #3796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions backend/database/a2a_agent_db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,12 @@ def _extract_base_url(url: str) -> str:
"""
from urllib.parse import urlparse
parsed = urlparse(url)
hostname = parsed.hostname or ""
if ":" in hostname:
hostname = f"[{hostname}]"
if parsed.port:
return f"{parsed.scheme}://{parsed.hostname}:{parsed.port}"
return f"{parsed.scheme}://{parsed.hostname}"
return f"{parsed.scheme}://{hostname}:{parsed.port}"
return f"{parsed.scheme}://{hostname}"

# Standard human-readable protocol label
PROTOCOL_HTTP_JSON = "HTTP+JSON"
Expand Down
7 changes: 7 additions & 0 deletions test/backend/database/test_a2a_agent_db.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -484,6 +484,13 @@ def artifact():
# Tests: Helper Functions
# ===========================================================================

class TestExtractBaseUrl:
def test_preserves_ipv6_brackets(self):
url = "https://[2001:db8::7]:8443/.well-known/agent-card.json"

assert a2a_db._extract_base_url(url) == "https://[2001:db8::7]:8443"


class TestGenerateTaskId:
def test_prefix(self):
assert a2a_db._generate_task_id().startswith('task_')
Expand Down