Allow [[...]] attributes on loop statements#124
Merged
Conversation
Add an attributes slot to the while, for and do-while loop rules so that [[name]] / [[name=expr]] / [[name(a, b)]] attributes can be attached to loops, matching the existing attachment points (functions, instructions, always-blocks and declarators). Since all three loop rules declare the same feature, it is hoisted onto the common LoopStatement supertype. The analyzer validates them uniformly across all three loop forms via a new `loop` AttributeUsage: attribute parameters are analyzed, unknown names produce the usual warning, and attributes registered only for other usages are rejected when placed on a loop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an attributes slot to the while, for, and do-while loop rules so that [[name]] / [[name=expr]] / [[name(a, b)]] attributes can be attached to loops, matching the existing attachment points (functions, instructions, always-blocks, and declarators). This might be useful in the future to guide HLS with custom attributes, for example, a partial unrolling factor.