Remove pilot notes and stop Jekyll processing the lab source - #240
Merged
Conversation
The three consolidated landing pages carried PILOT NOTE comment blocks marked "remove before publishing". They described the folder layout, which the Getting started pages and Labfiles/_shared/README.md already cover. Also excludes Labfiles/ and tools/ from the site build. Neither is meant to be published: lab code reaches learners by cloning the repo, and Jekyll was copying about 199 files from Labfiles into _site for no benefit. That exclusion is also the most likely fix for the Pages build failures. They began at 874158e, which touched only Labfiles and a workflow file - no Instructions content at all - so whatever Jekyll objected to is in the lab source it should never have been reading. Labfiles/_shared in particular holds template files containing {{TOKEN}} placeholders, which are not meant to reach a Liquid renderer. No page links into Labfiles by a site-relative path; the single reference is an absolute github.com URL in B1, which is unaffected. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: dc4690cc-57d6-48a7-abc8-bc8570113ab1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things
1. Removes the pilot notes. All three consolidated landing pages carried
PILOT NOTE (remove before publishing)comment blocks. They described the folder layout, which the Getting started pages andLabfiles/_shared/README.mdalready cover.2. Stops Jekyll processing the lab source — and this is most likely the Pages build fix.
On the Pages failures
Builds have failed since
874158e, with the last success at5017f7fon 14 August:5017f7f874158e(#232)c8f028f(#238)b0ff1d4(#233)The telling detail: #232 touched only
Labfiles/and a workflow file — noInstructions/content at all. So whatever Jekyll objected to is in lab source it was never meant to render.Labfiles/_shared/is the prime suspect. It holds template files containing{{LAB_FOLDER}},{{AZD_NAME}}and{{LAB_HINT}}placeholders — content that has no business reaching a Liquid renderer.This excludes
Labfiles/andtools/from the build. Neither should ever have been published: lab code reaches learners by cloning the repo, and Jekyll was copying about 199 files fromLabfilesinto_sitefor no benefit. Faster build, smaller site, and the template placeholders are out of Liquid's reach.Safety of the exclusion
No page links into
Labfilesby a site-relative path. The one reference — a data-folder link in B1 — is an absolutegithub.comURL and is unaffected.Honest caveat
I could not read the Pages build log; the API reports only "Page build failed." GitHub was also returning widespread 503s that day, and a build stuck building for hours points at infrastructure trouble too. So this is a well-reasoned fix, not a confirmed one — the test is whether the build goes green after merge.
If it doesn't, the next step is bisecting
_config.ymlexclusions, and it would be worth asking whoever owns Pages for the build log.Verification
All Tier 0 checks pass, plus
generate_lab_blocks.py --checkandsync.py --check._config.ymlparses, and both new exclusions are in place.